Make integration tests for fact gathering assert on failure

test/integration/inventory

@@ -4,6 +4,9 @@ testhost2 ansible_ssh_host=127.0.0.1 ansible_connection=local
 # For testing delegate_to
 testhost3 ansible_ssh_host=127.0.0.3
 testhost4 ansible_ssh_host=127.0.0.4
+# For testing fact gathering
+facthost[0:7] ansible_host=1270.0.0.1 ansible_connection=local
+
 
 # the following inline declarations are accompanied
 # by (preferred) group_vars/ and host_vars/ variables

test/integration/test_gathering_facts.yml

@@ -1,37 +1,116 @@
 ---
 
-- hosts: localhost
+- hosts: facthost0
-  tags: [ 'min' ]
+  tags: [ 'fact_min' ]
   connection: local
   gather_subset: "!all"
   gather_facts: yes
   tasks:
-    - debug: var={{item}}
+    - name: Test that only retrieving minimal facts work
-      with_items: [ 'ansible_user_id', 'ansible_interfaces', 'ansible_mounts', 'ansible_virtualization_role'  ]
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" == "UNDEF"'
 
-- hosts: localhost
+- hosts: facthost1
-  tags: [ 'network' ]
+  tags: [ 'fact_network' ]
   connection: local
   gather_subset: "network"
   gather_facts: yes
   tasks:
-    - debug: var={{item}}
+    - name: Test that retrieving network facts work
-      with_items: [ 'ansible_user_id', 'ansible_interfaces', 'ansible_mounts', 'ansible_virtualization_role' ]
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" == "UNDEF"'
 
-- hosts: localhost
+- hosts: facthost2
-  tags: [ 'hardware' ]
+  tags: [ 'fact_hardware' ]
   connection: local
   gather_subset: "hardware"
   gather_facts: yes
   tasks:
-    - debug: var={{item}}
+    - name: Test that retrieving hardware facts work
-      with_items: [ 'ansible_user_id', 'ansible_interfaces', 'ansible_mounts', 'ansible_virtualization_role' ]
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" == "UNDEF"'
 
-- hosts: localhost
+- hosts: facthost3
-  tags: [ 'virtual' ]
+  tags: [ 'fact_virtual' ]
   connection: local
   gather_subset: "virtual"
   gather_facts: yes
   tasks:
-    - debug: var={{item}}
+    - name: Test that retrieving virtualization facts work
-      with_items: [ 'ansible_user_id', 'ansible_interfaces', 'ansible_mounts', 'ansible_virtualization_role' ]
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" != "UNDEF"'
+
+- hosts: facthost4
+  tags: [ 'fact_comma_string' ]
+  connection: local
+  gather_subset: "virtual,network"
+  gather_facts: yes
+  tasks:
+    - name: Test that retrieving virtualization and network as a string works
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" != "UNDEF"'
+
+- hosts: facthost5
+  tags: [ 'fact_yaml_list' ]
+  connection: local
+  gather_subset:
+    - virtual
+    - network
+  gather_facts: yes
+  tasks:
+    - name: Test that retrieving virtualization and network as a string works
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" != "UNDEF"'
+
+- hosts: facthost6
+  tags: [ 'fact_negation' ]
+  connection: local
+  gather_subset: "!hardware"
+  gather_facts: yes
+  tasks:
+    - name: Test that negation of fact subsets work
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" != "UNDEF"'
+
+- hosts: facthost7
+  tags: [ 'fact_mixed_negation_addition' ]
+  connection: local
+  gather_subset: "!hardware,network"
+  gather_facts: yes
+  tasks:
+    - name: Test that negation and additional subsets work together
+      assert:
+        that:
+          - '"{{ ansible_user_id|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_interfaces|default("UNDEF") }}" != "UNDEF"'
+          - '"{{ ansible_mounts|default("UNDEF") }}" == "UNDEF"'
+          - '"{{ ansible_virtualization_role|default("UNDEF") }}" == "UNDEF"'
+