ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

apt_rpm: deprecate behavior of state=present and state=installed (#8285)

Browse source 
* Deprecate behavior of state=present and state=installed.

* Fix changelog fragment.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
Felix Fontein 2024-05-01 21:30:02 +02:00 committed by GitHub
parent 70adba8991
commit ea719649bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
changelogs/fragments/8285-apt_rpm-state-deprecate.yml Normal file
View file

@ -0,0 +1,7 @@
deprecated_features:
- "apt_rpm - the behavior of ``state=present`` and ``state=installed`` is deprecated and will change in community.general 11.0.0.
Right now the module will upgrade a package to the latest version if one of these two states is used. You should explicitly
use ``state=latest`` if you want this behavior, and switch to ``state=present_not_latest`` if you do not want to upgrade the
package if it is already installed. In community.general 11.0.0 the behavior of ``state=present`` and ``state=installed`` will
change to that of ``state=present_not_latest`` (https://github.com/ansible-collections/community.general/issues/8217,
https://github.com/ansible-collections/community.general/pull/8285)."

12
plugins/modules/apt_rpm.py
View file

@ -310,6 +310,18 @@ def main():
module.fail_json(msg="cannot find /usr/bin/apt-get and/or /usr/bin/rpm") module.fail_json(msg="cannot find /usr/bin/apt-get and/or /usr/bin/rpm")
p = module.params p = module.params
if p['state'] in ['installed', 'present']:
module.deprecate(
'state=%s currently behaves unexpectedly by always upgrading to the latest version if'
' the package is already installed. This behavior is deprecated and will change in'
' community.general 11.0.0. You can use state=latest to explicitly request this behavior'
' or state=present_not_latest to explicitly request the behavior that state=%s will have'
' in community.general 11.0.0, namely that the package will not be upgraded if it is'
' already installed.' % (p['state'], p['state']),
version='11.0.0',
collection_name='community.general',
)
modified = False modified = False
output = "" output = ""