From e85c7f848f2cce5ceb9a8f3d6393b412f7f1613f Mon Sep 17 00:00:00 2001 From: James Cammarata Date: Tue, 27 May 2014 14:09:50 -0500 Subject: [PATCH] Make sure export param for subversion module is checked as a boolean Fixes #7548 --- library/source_control/subversion | 2 +- test/integration/roles/test_subversion/tasks/main.yml | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/library/source_control/subversion b/library/source_control/subversion index 29d62240af..b28467c10f 100644 --- a/library/source_control/subversion +++ b/library/source_control/subversion @@ -176,7 +176,7 @@ def main(): username=dict(required=False), password=dict(required=False), executable=dict(default=None), - export=dict(default=False, required=False), + export=dict(default=False, required=False, type='bool'), ), supports_check_mode=True ) diff --git a/test/integration/roles/test_subversion/tasks/main.yml b/test/integration/roles/test_subversion/tasks/main.yml index 1b2d26529d..34eec23d48 100644 --- a/test/integration/roles/test_subversion/tasks/main.yml +++ b/test/integration/roles/test_subversion/tasks/main.yml @@ -94,12 +94,10 @@ subversion: repo={{ repo }} dest={{ checkout_dir }} export=True register: subverted4 -# FIXME: this needs to be fixed in the code see GitHub 6079 - -#- name: verify on a reclone things are marked unchanged -# assert: -# that: -# - "not subverted.changed" +- name: verify on a reclone things are marked unchanged + assert: + that: + - "not subverted4.changed" # TBA: test for additional options or URL variants welcome