From e7e2ab94daedf8093d8420f366bc7b0bd5e81777 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maty=C3=A1=C5=A1=20Kroupa?= Date: Thu, 21 Oct 2021 08:05:00 +0200 Subject: [PATCH] nmcli: Fix ipv6.dns not being recongnized as list (#3563) * nmcli: Fix ipv6.dns not being recongnized as list There was a missing comma on the previous line. * nmcli: Add changelog fragment for #3563 * nmcli: Update changelogs/fragments/3563-nmcli-ipv6_dns.yaml Make the fix description more descriptive Co-authored-by: Ajpantuso * nmcli: Remove ipv4.route-metric from list-typed properties Co-authored-by: Ajpantuso * nmcli: Update fragment 3563 with ipv4.route-metric bug Co-authored-by: Ajpantuso --- changelogs/fragments/3563-nmcli-ipv6_dns.yaml | 3 +++ plugins/modules/net_tools/nmcli.py | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/3563-nmcli-ipv6_dns.yaml diff --git a/changelogs/fragments/3563-nmcli-ipv6_dns.yaml b/changelogs/fragments/3563-nmcli-ipv6_dns.yaml new file mode 100644 index 0000000000..43f9ac76c5 --- /dev/null +++ b/changelogs/fragments/3563-nmcli-ipv6_dns.yaml @@ -0,0 +1,3 @@ +bugfixes: + - nmcli - fixed ``dns6`` option handling so that it is treated as a list internally (https://github.com/ansible-collections/community.general/pull/3563). + - nmcli - fixed ``ipv4.route-metric`` being in properties of type list (https://github.com/ansible-collections/community.general/pull/3563). diff --git a/plugins/modules/net_tools/nmcli.py b/plugins/modules/net_tools/nmcli.py index c6680c3bd3..83202f6ebc 100644 --- a/plugins/modules/net_tools/nmcli.py +++ b/plugins/modules/net_tools/nmcli.py @@ -1472,7 +1472,6 @@ class Nmcli(object): 'ipv4.dns-search', 'ipv4.routes', 'ipv4.routing-rules', - 'ipv4.route-metric' 'ipv6.dns', 'ipv6.dns-search', '802-11-wireless-security.group',