ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

[PR #8794/249126f4 backport][stable-8] proxmox inventory: fixing possible concatenation error (#8816)

Browse source 
proxmox inventory: fixing possible concatenation error (#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog

(cherry picked from commit 249126f429)

Co-authored-by: Simon Siebert <Mail@simonsiebert.de>
This commit is contained in:
patchback[bot] 2024-09-01 20:52:53 +02:00 committed by GitHub
parent a3d9f72462
commit e14ebe38f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/8794-Fixing-possible-concatination-error.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- proxmox inventory plugin - fixed a possible error on concatenating responses from proxmox. In case an API call unexpectedly returned an empty result, the inventory failed with a fatal error. Added check for empty response (https://github.com/ansible-collections/community.general/issues/8798, https://github.com/ansible-collections/community.general/pull/8794).

5
plugins/inventory/proxmox.py
View file

@ -329,8 +329,9 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
data = json['data'] data = json['data']
break break
else: else:
# /hosts 's 'results' is a list of all hosts, returned is paginated if json['data']:
data = data + json['data'] # /hosts 's 'results' is a list of all hosts, returned is paginated
data = data + json['data']
break break
self._cache[self.cache_key][url] = data self._cache[self.cache_key][url] = data