ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Rewrite method to not use try/except

Browse source 
Additional checks are not needed, because 'self.conn.get_entry(-1)'
returns all existing entries, each one should have state defined.
This commit is contained in:
Maciej Delmanowski 2015-07-25 18:15:23 +02:00 committed by Matt Clay
parent 1f65953090
commit e1084e5caa
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/ansible/modules/extras/cloud/misc/virt_net.py
View file

@ -317,18 +317,13 @@ class VirtNetwork(object):
return self.conn.find_entry(entryid) return self.conn.find_entry(entryid)
def list_nets(self, state=None): def list_nets(self, state=None):
entries = self.conn.find_entry(-1)
results = [] results = []
for x in entries: for entry in self.conn.find_entry(-1):
try: if state:
if state: if state == self.conn.get_status2(entry):
entrystate = self.conn.get_status2(x) results.append(entry.name())
if entrystate == state: else:
results.append(x.name()) results.append(entry.name())
else:
results.append(x.name())
except:
pass
return results return results
def state(self): def state(self):