ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

[PR #8100/b2b8fc30 backport][stable-8] HAProxy skips the wait when drain=true and the backend is down - fix issue 8092 (#8157)

Browse source 
HAProxy skips the wait when drain=true and the backend is down - fix issue 8092 (#8100)

* fix issue 8092

* "is not" => "!="

* moved the drain & down cause to the wait

* added changelogs for PR 8100

* fixed yaml

* fixed file type

* Apply suggestions from code review

Removed a dot from a comment

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/haproxy.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b2b8fc30bf)

Co-authored-by: RayJin2000 <rayjin2000@gmail.com>
This commit is contained in:
patchback[bot] 2024-03-28 12:34:51 +01:00 committed by GitHub
parent 63f4a16006
commit df8208afe1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/8100-haproxy-drain-fails-on-down-backend.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "haproxy - fix an issue where HAProxy could get stuck in DRAIN mode when the backend was unreachable (https://github.com/ansible-collections/community.general/issues/8092)."

2
plugins/modules/haproxy.py
View file

@ -343,7 +343,7 @@ class HAProxy(object):
if state is not None: if state is not None:
self.execute(Template(cmd).substitute(pxname=backend, svname=svname)) self.execute(Template(cmd).substitute(pxname=backend, svname=svname))
if self.wait: if self.wait and not (wait_for_status == "DRAIN" and state == "DOWN"):
self.wait_until_status(backend, svname, wait_for_status) self.wait_until_status(backend, svname, wait_for_status)
def get_state_for(self, pxname, svname): def get_state_for(self, pxname, svname):