udm_share: fix sanity checks (#5557) (#5609)

* udm_share: fix sanity checks

* add changelog fragment

(cherry picked from commit a3b748a15e)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

changelogs/fragments/5557-udm-share-sanity.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - udm_share - added ``elements`` attribute to ``list`` type parameters (https://github.com/ansible-collections/community.general/pull/5557).

plugins/modules/udm_share.py

@@ -125,6 +125,7 @@ options:
         description:
             - Option name in smb.conf and its value.
         type: list
+        elements: dict
         aliases: [ samba_custom_settings ]
     sambaDirectoryMode:
         default: '0755'
@@ -200,12 +201,14 @@ options:
         description:
             - Allowed host/network.
         type: list
+        elements: str
         aliases: [ samba_hosts_allow ]
     sambaHostsDeny:
         default: []
         description:
             - Denied host/network.
         type: list
+        elements: str
         aliases: [ samba_hosts_deny ]
     sambaInheritAcls:
         default: true
@@ -314,11 +317,13 @@ options:
         description:
             - Only allow access for this host, IP address or network.
         type: list
+        elements: str
     nfsCustomSettings:
         default: []
         description:
             - Option name in exports file.
         type: list
+        elements: str
         aliases: [ nfs_custom_settings ]
 '''
 
@@ -382,6 +387,7 @@ def main():
                                 aliases=['samba_csc_policy'],
                                 default='manual'),
             sambaCustomSettings=dict(type='list',
+                                     elements='dict',
                                      aliases=['samba_custom_settings'],
                                      default=[]),
             sambaDirectoryMode=dict(type='str',
@@ -418,9 +424,11 @@ def main():
                                      aliases=['samba_hide_unreadable'],
                                      default=False),
             sambaHostsAllow=dict(type='list',
+                                 elements='str',
                                  aliases=['samba_hosts_allow'],
                                  default=[]),
             sambaHostsDeny=dict(type='list',
+                                elements='str',
                                 aliases=['samba_hosts_deny'],
                                 default=[]),
             sambaInheritAcls=dict(type='bool',
@@ -474,8 +482,10 @@ def main():
                                 aliases=['samba_writeable'],
                                 default=True),
             nfs_hosts=dict(type='list',
+                           elements='str',
                            default=[]),
             nfsCustomSettings=dict(type='list',
+                                   elements='str',
                                    aliases=['nfs_custom_settings'],
                                    default=[]),
             state=dict(default='present',

tests/sanity/ignore-2.11.txt

@@ -25,7 +25,6 @@ plugins/modules/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/rax.py use-argspec-type-path # fix needed
 plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
 plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
-plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/xfconf.py validate-modules:return-syntax-error
 plugins/modules/yarn.py use-argspec-type-path
 tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6   # django generated code

tests/sanity/ignore-2.12.txt

@@ -20,6 +20,5 @@ plugins/modules/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/rax.py use-argspec-type-path # fix needed
 plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
 plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
-plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/xfconf.py validate-modules:return-syntax-error
 plugins/modules/yarn.py use-argspec-type-path

tests/sanity/ignore-2.13.txt

@@ -20,6 +20,5 @@ plugins/modules/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/rax.py use-argspec-type-path # fix needed
 plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
 plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
-plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/xfconf.py validate-modules:return-syntax-error
 plugins/modules/yarn.py use-argspec-type-path

tests/sanity/ignore-2.14.txt

@@ -21,7 +21,6 @@ plugins/modules/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/rax.py use-argspec-type-path # fix needed
 plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
 plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
-plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/udm_user.py import-3.11  # Uses deprecated stdlib library 'crypt'
 plugins/modules/xfconf.py validate-modules:return-syntax-error
 plugins/modules/yarn.py use-argspec-type-path

tests/sanity/ignore-2.15.txt

@@ -21,7 +21,6 @@ plugins/modules/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/rax.py use-argspec-type-path # fix needed
 plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
 plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
-plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/udm_user.py import-3.11  # Uses deprecated stdlib library 'crypt'
 plugins/modules/xfconf.py validate-modules:return-syntax-error
 plugins/modules/yarn.py use-argspec-type-path