mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
homebrew: Add info about changed packages (#31)
homebrew now returns details about changed and unchanged packages after performing the operations. Fixes: ansible/ansible#59376 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
parent
de0409e793
commit
d921968504
2 changed files with 45 additions and 2 deletions
2
changelogs/fragments/59376-homebrew_fix.yml
Normal file
2
changelogs/fragments/59376-homebrew_fix.yml
Normal file
|
@ -0,0 +1,2 @@
|
||||||
|
minor_changes:
|
||||||
|
- Add information about changed packages in homebrew returned facts (https://github.com/ansible/ansible/issues/59376).
|
|
@ -78,6 +78,7 @@ notes:
|
||||||
- When used with a `loop:` each package will be processed individually,
|
- When used with a `loop:` each package will be processed individually,
|
||||||
it is much more efficient to pass the list directly to the `name` option.
|
it is much more efficient to pass the list directly to the `name` option.
|
||||||
'''
|
'''
|
||||||
|
|
||||||
EXAMPLES = '''
|
EXAMPLES = '''
|
||||||
# Install formula foo with 'brew' in default path (C(/usr/local/bin))
|
# Install formula foo with 'brew' in default path (C(/usr/local/bin))
|
||||||
- homebrew:
|
- homebrew:
|
||||||
|
@ -135,6 +136,28 @@ EXAMPLES = '''
|
||||||
upgrade_options: ignored-pinned
|
upgrade_options: ignored-pinned
|
||||||
'''
|
'''
|
||||||
|
|
||||||
|
RETURN = '''
|
||||||
|
msg:
|
||||||
|
description: if the cache was updated or not
|
||||||
|
returned: always
|
||||||
|
type: str
|
||||||
|
sample: "Changed: 0, Unchanged: 2"
|
||||||
|
unchanged_pkgs:
|
||||||
|
description:
|
||||||
|
- List of package names which are unchanged after module run
|
||||||
|
- "Added in version 2.10"
|
||||||
|
returned: success
|
||||||
|
type: list
|
||||||
|
sample: ["awscli", "ag"]
|
||||||
|
changed_pkgs:
|
||||||
|
description:
|
||||||
|
- List of package names which are changed after module run
|
||||||
|
- "Added in version 2.10"
|
||||||
|
returned: success
|
||||||
|
type: list
|
||||||
|
sample: ['git', 'git-cola']
|
||||||
|
'''
|
||||||
|
|
||||||
import os.path
|
import os.path
|
||||||
import re
|
import re
|
||||||
|
|
||||||
|
@ -389,6 +412,8 @@ class Homebrew(object):
|
||||||
self.changed = False
|
self.changed = False
|
||||||
self.changed_count = 0
|
self.changed_count = 0
|
||||||
self.unchanged_count = 0
|
self.unchanged_count = 0
|
||||||
|
self.changed_pkgs = []
|
||||||
|
self.unchanged_pkgs = []
|
||||||
self.message = ''
|
self.message = ''
|
||||||
|
|
||||||
def _setup_instance_vars(self, **kwargs):
|
def _setup_instance_vars(self, **kwargs):
|
||||||
|
@ -519,6 +544,7 @@ class Homebrew(object):
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Homebrew would be updated.'
|
self.message = 'Homebrew would be updated.'
|
||||||
raise HomebrewException(self.message)
|
raise HomebrewException(self.message)
|
||||||
|
|
||||||
rc, out, err = self.module.run_command([
|
rc, out, err = self.module.run_command([
|
||||||
self.brew_path,
|
self.brew_path,
|
||||||
'update',
|
'update',
|
||||||
|
@ -576,6 +602,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if self._current_package_is_installed():
|
if self._current_package_is_installed():
|
||||||
self.unchanged_count += 1
|
self.unchanged_count += 1
|
||||||
|
self.unchanged_pkgs.append(self.current_package)
|
||||||
self.message = 'Package already installed: {0}'.format(
|
self.message = 'Package already installed: {0}'.format(
|
||||||
self.current_package,
|
self.current_package,
|
||||||
)
|
)
|
||||||
|
@ -603,6 +630,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if self._current_package_is_installed():
|
if self._current_package_is_installed():
|
||||||
self.changed_count += 1
|
self.changed_count += 1
|
||||||
|
self.changed_pkgs.append(self.current_package)
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Package installed: {0}'.format(self.current_package)
|
self.message = 'Package installed: {0}'.format(self.current_package)
|
||||||
return True
|
return True
|
||||||
|
@ -636,6 +664,7 @@ class Homebrew(object):
|
||||||
self.current_package,
|
self.current_package,
|
||||||
)
|
)
|
||||||
self.unchanged_count += 1
|
self.unchanged_count += 1
|
||||||
|
self.unchanged_pkgs.append(self.current_package)
|
||||||
return True
|
return True
|
||||||
|
|
||||||
if self.module.check_mode:
|
if self.module.check_mode:
|
||||||
|
@ -655,6 +684,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if self._current_package_is_installed() and not self._current_package_is_outdated():
|
if self._current_package_is_installed() and not self._current_package_is_outdated():
|
||||||
self.changed_count += 1
|
self.changed_count += 1
|
||||||
|
self.changed_pkgs.append(self.current_package)
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Package upgraded: {0}'.format(self.current_package)
|
self.message = 'Package upgraded: {0}'.format(self.current_package)
|
||||||
return True
|
return True
|
||||||
|
@ -699,6 +729,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if not self._current_package_is_installed():
|
if not self._current_package_is_installed():
|
||||||
self.unchanged_count += 1
|
self.unchanged_count += 1
|
||||||
|
self.unchanged_pkgs.append(self.current_package)
|
||||||
self.message = 'Package already uninstalled: {0}'.format(
|
self.message = 'Package already uninstalled: {0}'.format(
|
||||||
self.current_package,
|
self.current_package,
|
||||||
)
|
)
|
||||||
|
@ -721,6 +752,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if not self._current_package_is_installed():
|
if not self._current_package_is_installed():
|
||||||
self.changed_count += 1
|
self.changed_count += 1
|
||||||
|
self.changed_pkgs.append(self.current_package)
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Package uninstalled: {0}'.format(self.current_package)
|
self.message = 'Package uninstalled: {0}'.format(self.current_package)
|
||||||
return True
|
return True
|
||||||
|
@ -766,6 +798,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if rc == 0:
|
if rc == 0:
|
||||||
self.changed_count += 1
|
self.changed_count += 1
|
||||||
|
self.changed_pkgs.append(self.current_package)
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Package linked: {0}'.format(self.current_package)
|
self.message = 'Package linked: {0}'.format(self.current_package)
|
||||||
|
|
||||||
|
@ -812,6 +845,7 @@ class Homebrew(object):
|
||||||
|
|
||||||
if rc == 0:
|
if rc == 0:
|
||||||
self.changed_count += 1
|
self.changed_count += 1
|
||||||
|
self.changed_pkgs.append(self.current_package)
|
||||||
self.changed = True
|
self.changed = True
|
||||||
self.message = 'Package unlinked: {0}'.format(self.current_package)
|
self.message = 'Package unlinked: {0}'.format(self.current_package)
|
||||||
|
|
||||||
|
@ -920,10 +954,17 @@ def main():
|
||||||
upgrade_all=upgrade_all, install_options=install_options,
|
upgrade_all=upgrade_all, install_options=install_options,
|
||||||
upgrade_options=upgrade_options)
|
upgrade_options=upgrade_options)
|
||||||
(failed, changed, message) = brew.run()
|
(failed, changed, message) = brew.run()
|
||||||
|
changed_pkgs = brew.changed_pkgs
|
||||||
|
unchanged_pkgs = brew.unchanged_pkgs
|
||||||
|
|
||||||
if failed:
|
if failed:
|
||||||
module.fail_json(msg=message)
|
module.fail_json(msg=message)
|
||||||
else:
|
module.exit_json(
|
||||||
module.exit_json(changed=changed, msg=message)
|
changed=changed,
|
||||||
|
msg=message,
|
||||||
|
unchanged_pkgs=unchanged_pkgs,
|
||||||
|
changed_pkgs=changed_pkgs
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
if __name__ == '__main__':
|
if __name__ == '__main__':
|
||||||
|
|
Loading…
Reference in a new issue