mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
Merge pull request #9720 from vlajos/typofixes-vlajos-20141204
typofixes - https://github.com/vlajos/misspell_fixer
This commit is contained in:
commit
d4da58e102
24 changed files with 31 additions and 31 deletions
|
@ -453,7 +453,7 @@ gives them slightly higher development priority (though they'll work in exactly
|
||||||
Deprecating and making module aliases
|
Deprecating and making module aliases
|
||||||
``````````````````````````````````````
|
``````````````````````````````````````
|
||||||
|
|
||||||
Starting in 1.8 you can deprecate modules by renaming them with a preceeding _, i.e. old_cloud.py to
|
Starting in 1.8 you can deprecate modules by renaming them with a preceding _, i.e. old_cloud.py to
|
||||||
_old_cloud.py, This will keep the module available but hide it from the primary docs and listing.
|
_old_cloud.py, This will keep the module available but hide it from the primary docs and listing.
|
||||||
|
|
||||||
You can also rename modules and keep an alias to the old name by using a symlink that starts with _.
|
You can also rename modules and keep an alias to the old name by using a symlink that starts with _.
|
||||||
|
|
|
@ -29,7 +29,7 @@ and then commenting on that particular issue on GitHub. Here's how:
|
||||||
or Docker for this, but they are optional. It is also useful to have virtual machines of different Linux or
|
or Docker for this, but they are optional. It is also useful to have virtual machines of different Linux or
|
||||||
other flavors, since some features (apt vs. yum, for example) are specific to those OS versions.
|
other flavors, since some features (apt vs. yum, for example) are specific to those OS versions.
|
||||||
|
|
||||||
First, you will need to configure your testing environment with the neccessary tools required to run our test
|
First, you will need to configure your testing environment with the necessary tools required to run our test
|
||||||
suites. You will need at least::
|
suites. You will need at least::
|
||||||
|
|
||||||
git
|
git
|
||||||
|
|
|
@ -149,7 +149,7 @@ it will be automatically discoverable via a dynamic group like so::
|
||||||
tasks:
|
tasks:
|
||||||
- ping
|
- ping
|
||||||
|
|
||||||
Using this philosophy can be a great way to keep systems seperated by the function they perform.
|
Using this philosophy can be a great way to keep systems separated by the function they perform.
|
||||||
|
|
||||||
In this example, if we wanted to define variables that are automatically applied to each machine tagged with the 'class' of 'webserver', 'group_vars'
|
In this example, if we wanted to define variables that are automatically applied to each machine tagged with the 'class' of 'webserver', 'group_vars'
|
||||||
in ansible can be used. See :doc:`splitting_out_vars`.
|
in ansible can be used. See :doc:`splitting_out_vars`.
|
||||||
|
|
|
@ -147,7 +147,7 @@ filter_plugins = /usr/share/ansible_plugins/filter_plugins
|
||||||
# avoid issues.
|
# avoid issues.
|
||||||
#http_user_agent = ansible-agent
|
#http_user_agent = ansible-agent
|
||||||
|
|
||||||
# if set to a persistant type (not 'memory', for example 'redis') fact values
|
# if set to a persistent type (not 'memory', for example 'redis') fact values
|
||||||
# from previous runs in Ansible will be stored. This may be useful when
|
# from previous runs in Ansible will be stored. This may be useful when
|
||||||
# wanting to use, for example, IP information from one group of servers
|
# wanting to use, for example, IP information from one group of servers
|
||||||
# without having to talk to them in the same playbook run to get their
|
# without having to talk to them in the same playbook run to get their
|
||||||
|
|
|
@ -58,7 +58,7 @@ def parse():
|
||||||
parser.add_option('-D', '--debugger', dest='debugger',
|
parser.add_option('-D', '--debugger', dest='debugger',
|
||||||
help="path to python debugger (e.g. /usr/bin/pdb)")
|
help="path to python debugger (e.g. /usr/bin/pdb)")
|
||||||
parser.add_option('-I', '--interpreter', dest='interpreter',
|
parser.add_option('-I', '--interpreter', dest='interpreter',
|
||||||
help="path to interpeter to use for this module (e.g. ansible_python_interpreter=/usr/bin/python)",
|
help="path to interpreter to use for this module (e.g. ansible_python_interpreter=/usr/bin/python)",
|
||||||
metavar='INTERPRETER_TYPE=INTERPRETER_PATH')
|
metavar='INTERPRETER_TYPE=INTERPRETER_PATH')
|
||||||
parser.add_option('-c', '--check', dest='check', action='store_true',
|
parser.add_option('-c', '--check', dest='check', action='store_true',
|
||||||
help="run the module in check mode")
|
help="run the module in check mode")
|
||||||
|
@ -104,7 +104,7 @@ def boilerplate_module(modfile, args, interpreter, check):
|
||||||
inject = {}
|
inject = {}
|
||||||
if interpreter:
|
if interpreter:
|
||||||
if '=' not in interpreter:
|
if '=' not in interpreter:
|
||||||
print 'interpeter must by in the form of ansible_python_interpreter=/usr/bin/python'
|
print 'interpreter must by in the form of ansible_python_interpreter=/usr/bin/python'
|
||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
interpreter_type, interpreter_path = interpreter.split('=')
|
interpreter_type, interpreter_path = interpreter.split('=')
|
||||||
if not interpreter_type.startswith('ansible_'):
|
if not interpreter_type.startswith('ansible_'):
|
||||||
|
|
|
@ -1355,7 +1355,7 @@ class HPUX(Hardware):
|
||||||
self.facts['memtotal_mb'] = int(data) / 1024
|
self.facts['memtotal_mb'] = int(data) / 1024
|
||||||
except AttributeError:
|
except AttributeError:
|
||||||
#For systems where memory details aren't sent to syslog or the log has rotated, use parsed
|
#For systems where memory details aren't sent to syslog or the log has rotated, use parsed
|
||||||
#adb output. Unfortunatley /dev/kmem doesn't have world-read, so this only works as root.
|
#adb output. Unfortunately /dev/kmem doesn't have world-read, so this only works as root.
|
||||||
if os.access("/dev/kmem", os.R_OK):
|
if os.access("/dev/kmem", os.R_OK):
|
||||||
rc, out, err = module.run_command("echo 'phys_mem_pages/D' | adb -k /stand/vmunix /dev/kmem | tail -1 | awk '{print $2}'", use_unsafe_shell=True)
|
rc, out, err = module.run_command("echo 'phys_mem_pages/D' | adb -k /stand/vmunix /dev/kmem | tail -1 | awk '{print $2}'", use_unsafe_shell=True)
|
||||||
if not err:
|
if not err:
|
||||||
|
|
|
@ -986,7 +986,7 @@ class Runner(object):
|
||||||
# render module_args and complex_args templates
|
# render module_args and complex_args templates
|
||||||
try:
|
try:
|
||||||
# When templating module_args, we need to be careful to ensure
|
# When templating module_args, we need to be careful to ensure
|
||||||
# that no variables inadvertantly (or maliciously) add params
|
# that no variables inadvertently (or maliciously) add params
|
||||||
# to the list of args. We do this by counting the number of k=v
|
# to the list of args. We do this by counting the number of k=v
|
||||||
# pairs before and after templating.
|
# pairs before and after templating.
|
||||||
num_args_pre = self._count_module_args(module_args, allow_dupes=True)
|
num_args_pre = self._count_module_args(module_args, allow_dupes=True)
|
||||||
|
|
|
@ -220,7 +220,7 @@
|
||||||
- name: clean up
|
- name: clean up
|
||||||
file: dest=/tmp/worldwritable state=absent
|
file: dest=/tmp/worldwritable state=absent
|
||||||
|
|
||||||
# test overwritting a link using "follow=yes" so that the link
|
# test overwriting a link using "follow=yes" so that the link
|
||||||
# is preserved and the link target is updated
|
# is preserved and the link target is updated
|
||||||
|
|
||||||
- name: create a test file to symlink to
|
- name: create a test file to symlink to
|
||||||
|
|
|
@ -188,7 +188,7 @@
|
||||||
- "file11_result.uid == 1235"
|
- "file11_result.uid == 1235"
|
||||||
|
|
||||||
- name: fail to create soft link to non existent file
|
- name: fail to create soft link to non existent file
|
||||||
file: src=/noneexistant dest={{output_dir}}/soft2.txt state=link force=no
|
file: src=/noneexistent dest={{output_dir}}/soft2.txt state=link force=no
|
||||||
register: file12_result
|
register: file12_result
|
||||||
ignore_errors: true
|
ignore_errors: true
|
||||||
|
|
||||||
|
@ -198,7 +198,7 @@
|
||||||
- "file12_result.failed == true"
|
- "file12_result.failed == true"
|
||||||
|
|
||||||
- name: force creation soft link to non existent
|
- name: force creation soft link to non existent
|
||||||
file: src=/noneexistant dest={{output_dir}}/soft2.txt state=link force=yes
|
file: src=/noneexistent dest={{output_dir}}/soft2.txt state=link force=yes
|
||||||
register: file13_result
|
register: file13_result
|
||||||
|
|
||||||
- name: verify that link was created
|
- name: verify that link was created
|
||||||
|
|
|
@ -243,7 +243,7 @@
|
||||||
that:
|
that:
|
||||||
- "result.stat.checksum == 'f9af7008e3cb67575ce653d094c79cabebf6e523'"
|
- "result.stat.checksum == 'f9af7008e3cb67575ce653d094c79cabebf6e523'"
|
||||||
|
|
||||||
# Test EOF with empty file to make sure no unneccessary newline is added
|
# Test EOF with empty file to make sure no unnecessary newline is added
|
||||||
- name: testempty deploy the testempty file for lineinfile
|
- name: testempty deploy the testempty file for lineinfile
|
||||||
copy: src=testempty.txt dest={{output_dir}}/testempty.txt
|
copy: src=testempty.txt dest={{output_dir}}/testempty.txt
|
||||||
register: result
|
register: result
|
||||||
|
|
|
@ -41,7 +41,7 @@
|
||||||
- "result.changed == true"
|
- "result.changed == true"
|
||||||
- "result.db =='{{ db_name }}'"
|
- "result.db =='{{ db_name }}'"
|
||||||
|
|
||||||
- name: assert database was backup succesfully
|
- name: assert database was backup successfully
|
||||||
command: file {{ db_file_name }}
|
command: file {{ db_file_name }}
|
||||||
register: result
|
register: result
|
||||||
|
|
||||||
|
|
|
@ -153,22 +153,22 @@
|
||||||
- include: user_password_update_test.yml
|
- include: user_password_update_test.yml
|
||||||
|
|
||||||
# ============================================================
|
# ============================================================
|
||||||
# Assert create user with SELECT privileges, attemp to create database and update privileges to create database
|
# Assert create user with SELECT privileges, attempt to create database and update privileges to create database
|
||||||
#
|
#
|
||||||
- include: test_privs.yml current_privilege=SELECT current_append_privs=no
|
- include: test_privs.yml current_privilege=SELECT current_append_privs=no
|
||||||
|
|
||||||
# ============================================================
|
# ============================================================
|
||||||
# Assert creating user with SELECT privileges, attemp to create database and append privileges to create database
|
# Assert creating user with SELECT privileges, attempt to create database and append privileges to create database
|
||||||
#
|
#
|
||||||
- include: test_privs.yml current_privilege=DROP current_append_privs=yes
|
- include: test_privs.yml current_privilege=DROP current_append_privs=yes
|
||||||
|
|
||||||
# ============================================================
|
# ============================================================
|
||||||
# Assert create user with SELECT privileges, attemp to create database and update privileges to create database
|
# Assert create user with SELECT privileges, attempt to create database and update privileges to create database
|
||||||
#
|
#
|
||||||
- include: test_privs.yml current_privilege='UPDATE,ALTER' current_append_privs=no
|
- include: test_privs.yml current_privilege='UPDATE,ALTER' current_append_privs=no
|
||||||
|
|
||||||
# ============================================================
|
# ============================================================
|
||||||
# Assert creating user with SELECT privileges, attemp to create database and append privileges to create database
|
# Assert creating user with SELECT privileges, attempt to create database and append privileges to create database
|
||||||
#
|
#
|
||||||
- include: test_privs.yml current_privilege='INSERT,DELETE' current_append_privs=yes
|
- include: test_privs.yml current_privilege='INSERT,DELETE' current_append_privs=yes
|
||||||
|
|
||||||
|
|
|
@ -72,7 +72,7 @@
|
||||||
register: win_stat_no_args
|
register: win_stat_no_args
|
||||||
ignore_errors: true
|
ignore_errors: true
|
||||||
|
|
||||||
- name: check win_stat result witn no path argument
|
- name: check win_stat result with no path argument
|
||||||
assert:
|
assert:
|
||||||
that:
|
that:
|
||||||
- "win_stat_no_args|failed"
|
- "win_stat_no_args|failed"
|
||||||
|
|
|
@ -329,5 +329,5 @@ class TestModuleUtilsBasicHelpers(unittest.TestCase):
|
||||||
|
|
||||||
# The overzealous-ness here may lead to us changing the algorithm in
|
# The overzealous-ness here may lead to us changing the algorithm in
|
||||||
# the future. We could make it consume less of the data (with the
|
# the future. We could make it consume less of the data (with the
|
||||||
# possiblity of leaving partial passwords exposed) and encourage
|
# possibility of leaving partial passwords exposed) and encourage
|
||||||
# people to use no_log instead of relying on this obfuscation.
|
# people to use no_log instead of relying on this obfuscation.
|
||||||
|
|
|
@ -717,7 +717,7 @@ class TestUtils(unittest.TestCase):
|
||||||
# jinja2 loop blocks with lots of complexity
|
# jinja2 loop blocks with lots of complexity
|
||||||
_test_combo(
|
_test_combo(
|
||||||
# in memory of neighbors cat
|
# in memory of neighbors cat
|
||||||
# we preserve line breaks unless a line continuation character preceeds them
|
# we preserve line breaks unless a line continuation character precedes them
|
||||||
'a {% if x %} y {%else %} {{meow}} {% endif %} "cookie\nchip" \\\ndone\nand done',
|
'a {% if x %} y {%else %} {{meow}} {% endif %} "cookie\nchip" \\\ndone\nand done',
|
||||||
['a', '{% if x %}', 'y', '{%else %}', '{{meow}}', '{% endif %}', '"cookie\nchip"', 'done\n', 'and', 'done']
|
['a', '{% if x %}', 'y', '{%else %}', '{{meow}}', '{% endif %}', '"cookie\nchip"', 'done\n', 'and', 'done']
|
||||||
)
|
)
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
Submission Recieved
|
Submission Received
|
||||||
===================
|
===================
|
||||||
|
|
||||||
Hi!
|
Hi!
|
||||||
|
|
|
@ -6,7 +6,7 @@ Hi!
|
||||||
Thanks very much for your interest in Ansible. It sincerely means a lot to us.
|
Thanks very much for your interest in Ansible. It sincerely means a lot to us.
|
||||||
|
|
||||||
This appears to be a submission about a module, and aside from action_plugins, if you know what those are, the modules
|
This appears to be a submission about a module, and aside from action_plugins, if you know what those are, the modules
|
||||||
in ansible are now moved two seperate repos. We would appreciate if you can submit this there instead.
|
in ansible are now moved two separate repos. We would appreciate if you can submit this there instead.
|
||||||
|
|
||||||
If this is about a new module, submit pull requests or ideas to:
|
If this is about a new module, submit pull requests or ideas to:
|
||||||
|
|
||||||
|
|
|
@ -14,7 +14,7 @@ open dialog. You can stop by the development list, and we'd be glad to talk abo
|
||||||
|
|
||||||
* https://groups.google.com/forum/#!forum/ansible-devel
|
* https://groups.google.com/forum/#!forum/ansible-devel
|
||||||
|
|
||||||
In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always neccessary.
|
In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always necessary.
|
||||||
|
|
||||||
Thank you once again for this and your interest in Ansible!
|
Thank you once again for this and your interest in Ansible!
|
||||||
|
|
||||||
|
|
|
@ -15,7 +15,7 @@ However, we're absolutely always up for discussion. Since this is a really busy
|
||||||
|
|
||||||
* https://groups.google.com/forum/#!forum/ansible-devel
|
* https://groups.google.com/forum/#!forum/ansible-devel
|
||||||
|
|
||||||
In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always neccessary.
|
In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always necessary.
|
||||||
|
|
||||||
Thank you once again for this and your interest in Ansible!
|
Thank you once again for this and your interest in Ansible!
|
||||||
|
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
Submission Recieved
|
Submission Received
|
||||||
===================
|
===================
|
||||||
|
|
||||||
Hi!
|
Hi!
|
||||||
|
|
|
@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
|
||||||
__metaclass__ = type
|
__metaclass__ = type
|
||||||
|
|
||||||
'''
|
'''
|
||||||
Compat library for ansible. This contains compatiblity definitions for older python
|
Compat library for ansible. This contains compatibility definitions for older python
|
||||||
When we need to import a module differently depending on python version, do it
|
When we need to import a module differently depending on python version, do it
|
||||||
here. Then in the code we can simply import from compat in order to get what we want.
|
here. Then in the code we can simply import from compat in order to get what we want.
|
||||||
'''
|
'''
|
||||||
|
|
|
@ -61,7 +61,7 @@ class AnsibleError(Exception):
|
||||||
def _get_error_lines_from_file(self, file_name, line_number):
|
def _get_error_lines_from_file(self, file_name, line_number):
|
||||||
'''
|
'''
|
||||||
Returns the line in the file which coresponds to the reported error
|
Returns the line in the file which coresponds to the reported error
|
||||||
location, as well as the line preceeding it (if the error did not
|
location, as well as the line preceding it (if the error did not
|
||||||
occur on the first line), to provide context to the error.
|
occur on the first line), to provide context to the error.
|
||||||
'''
|
'''
|
||||||
|
|
||||||
|
@ -82,7 +82,7 @@ class AnsibleError(Exception):
|
||||||
Given an object reporting the location of the exception in a file, return
|
Given an object reporting the location of the exception in a file, return
|
||||||
detailed information regarding it including:
|
detailed information regarding it including:
|
||||||
|
|
||||||
* the line which caused the error as well as the one preceeding it
|
* the line which caused the error as well as the one preceding it
|
||||||
* causes and suggested remedies for common syntax errors
|
* causes and suggested remedies for common syntax errors
|
||||||
|
|
||||||
If this error was created with show_content=False, the reporting of content
|
If this error was created with show_content=False, the reporting of content
|
||||||
|
|
|
@ -130,12 +130,12 @@ class DataLoader():
|
||||||
show_content = False
|
show_content = False
|
||||||
return (data, show_content)
|
return (data, show_content)
|
||||||
except (IOError, OSError) as e:
|
except (IOError, OSError) as e:
|
||||||
raise AnsibleParserError("an error occured while trying to read the file '%s': %s" % (file_name, str(e)))
|
raise AnsibleParserError("an error occurred while trying to read the file '%s': %s" % (file_name, str(e)))
|
||||||
|
|
||||||
def _handle_error(self, yaml_exc, file_name, show_content):
|
def _handle_error(self, yaml_exc, file_name, show_content):
|
||||||
'''
|
'''
|
||||||
Optionally constructs an object (AnsibleBaseYAMLObject) to encapsulate the
|
Optionally constructs an object (AnsibleBaseYAMLObject) to encapsulate the
|
||||||
file name/position where a YAML exception occured, and raises an AnsibleParserError
|
file name/position where a YAML exception occurred, and raises an AnsibleParserError
|
||||||
to display the syntax exception information.
|
to display the syntax exception information.
|
||||||
'''
|
'''
|
||||||
|
|
||||||
|
|
|
@ -170,7 +170,7 @@ class Play(Base):
|
||||||
|
|
||||||
if len(self.roles) > 0:
|
if len(self.roles) > 0:
|
||||||
for ri in self.roles:
|
for ri in self.roles:
|
||||||
# The internal list of roles are actualy RoleInclude objects,
|
# The internal list of roles are actually RoleInclude objects,
|
||||||
# so we load the role from that now
|
# so we load the role from that now
|
||||||
role = Role.load(ri)
|
role = Role.load(ri)
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue