ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix a couple issues in synchronize with docker (#23047)

Browse source 
* Fix a couple issues in synchronize with docker

* Make the rsync_opts parse as a list using the same criteria as
  module_utils argumentspec parsing
* Do not quote arguments in the action plugin.  The module will quote as
  it knows whether it will invoke rsync with a shell or via exec.

Fixes #23046
This commit is contained in:
Toshio Kuratomi 2017-03-28 11:38:37 -07:00 committed by GitHub
parent ccfa464464
commit d3a1aea7c5
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
lib/ansible/plugins/action/synchronize.py
View file

@ -18,11 +18,14 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
import os.path import os.path
from collections import MutableSequence
from ansible import constants as C
from ansible.module_utils.six import string_types
from ansible.module_utils._text import to_text
from ansible.playbook.play_context import MAGIC_VARIABLE_MAPPING from ansible.playbook.play_context import MAGIC_VARIABLE_MAPPING
from ansible.plugins.action import ActionBase from ansible.plugins.action import ActionBase
from ansible.plugins import connection_loader from ansible.plugins import connection_loader
from ansible import constants as C
boolean = C.mk_boolean boolean = C.mk_boolean
@ -364,9 +367,7 @@ class ActionModule(ActionBase):
# to. # to.
self._play_context.become = False self._play_context.become = False
# make sure rsync path is quoted. _tmp_args['rsync_path'] = rsync_path
if rsync_path:
_tmp_args['rsync_path'] = '"%s"' % rsync_path
if use_ssh_args: if use_ssh_args:
ssh_args = [ ssh_args = [
@ -379,16 +380,23 @@ class ActionModule(ActionBase):
# If launching synchronize against docker container # If launching synchronize against docker container
# use rsync_opts to support container to override rsh options # use rsync_opts to support container to override rsh options
if self._remote_transport in [ 'docker' ]: if self._remote_transport in [ 'docker' ]:
if not isinstance(_tmp_args.get('rsync_opts'), list): # Replicate what we do in the module argumentspec handling for lists
_tmp_args['rsync_opts'] = self._task.args.get('rsync_opts', '').split(' ') if not isinstance(_tmp_args.get('rsync_opts'), MutableSequence):
tmp_rsync_opts = _tmp_args.get('rsync_opts', [])
if isinstance(tmp_rsync_opts, string_types):
tmp_rsync_opts = tmp_rsync_opts.split(',')
elif isinstance(tmp_rsync_opts, (int, float)):
tmp_rsync_opts = [to_text(tmp_rsync_opts)]
_tmp_args['rsync_opts'] = tmp_rsync_opts
if '--blocking-io' not in _tmp_args['rsync_opts']: if '--blocking-io' not in _tmp_args['rsync_opts']:
_tmp_args['rsync_opts'].append('--blocking-io') _tmp_args['rsync_opts'].append('--blocking-io')
if become and self._play_context.become_user: if become and self._play_context.become_user:
_tmp_args['rsync_opts'].append("--rsh='%s exec -u %s -i'" % (self._docker_cmd, self._play_context.become_user)) _tmp_args['rsync_opts'].append("--rsh=%s exec -u %s -i" % (self._docker_cmd, self._play_context.become_user))
elif user is not None: elif user is not None:
_tmp_args['rsync_opts'].append("--rsh='%s exec -u %s -i'" % (self._docker_cmd, user)) _tmp_args['rsync_opts'].append("--rsh=%s exec -u %s -i" % (self._docker_cmd, user))
else: else:
_tmp_args['rsync_opts'].append("--rsh='%s exec -i'" % self._docker_cmd) _tmp_args['rsync_opts'].append("--rsh=%s exec -i" % self._docker_cmd)
# run the module and store the result # run the module and store the result
result.update(self._execute_module('synchronize', module_args=_tmp_args, task_vars=task_vars)) result.update(self._execute_module('synchronize', module_args=_tmp_args, task_vars=task_vars))