ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix uninitialized variable in deserialize method (#18037)

Browse source 
The bug was introduced with commit 06d4f4ad0e.
Added a simple test.
This commit is contained in:
Thilo Uttendorfer 2016-10-21 04:54:16 +02:00 committed by jctanner
parent 0a60cceaf0
commit cf0da0948d
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/playbook/block.py
View file

@ -251,7 +251,7 @@ class Block(Base, Become, Conditional, Taggable):
p = TaskInclude()
elif parent_type == 'HandlerTaskInclude':
p = HandlerTaskInclude()
p.deserialize(pb_data)
p.deserialize(parent_data)
self._parent = p
self._dep_chain = self._parent.get_dep_chain()

11
test/units/playbook/test_block.py
View file

@ -75,3 +75,14 @@ class TestBlock(unittest.TestCase):
self.assertEqual(len(b.block), 1)
self.assertIsInstance(b.block[0], Task)
def test_deserialize(self):
ds = dict(
block = [dict(action='block')],
rescue = [dict(action='rescue')],
always = [dict(action='always')],
)
b = Block.load(ds)
data = dict(parent = ds, parent_type = 'Block')
b.deserialize(data)
self.assertIsInstance(b._parent, Block)