ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

gitlab_project_members: improve project name matching (#3602)

Browse source 
* Update gitlab_project_members.py

The actual search method doesn't accept path with namespace for project_name. If you have many project with same name, this module gitlab_project_members can't work.

* Update gitlab_project_members.py

* Update gitlab_project_members.py

* Update gitlab_project_members.py

* Create 3602-fix-gitlab_project_members-improve-search-method

* Rename 3602-fix-gitlab_project_members-improve-search-method to 3602-fix-gitlab_project_members-improve-search-method.yml
This commit is contained in:
paytroff 2021-10-30 08:15:12 +02:00 committed by GitHub
parent 9fb76efde0
commit cdfc4dcf49
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/3602-fix-gitlab_project_members-improve-search-method.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- gitlab_project_members - ``get_project_id`` return the project id by matching ``full_path`` or ``name`` (https://github.com/ansible-collections/community.general/pull/3602).

12
plugins/modules/source_control/gitlab/gitlab_project_members.py
View file

@ -48,7 +48,7 @@ options:
type: str type: str
project: project:
description: description:
- The name of the GitLab project the member is added to/removed from. - The name (or full path) of the GitLab project the member is added to/removed from.
required: true required: true
type: str type: str
gitlab_user: gitlab_user:
@ -194,9 +194,13 @@ class GitLabProjectMembers(object):
self._gitlab = gl self._gitlab = gl
def get_project(self, project_name): def get_project(self, project_name):
project_exists = self._gitlab.projects.list(search=project_name) try:
if project_exists: project_exists = self._gitlab.projects.get(project_name)
return project_exists[0].id return project_exists.id
except gitlab.exceptions.GitlabGetError as e:
project_exists = self._gitlab.projects.list(search=project_name)
if project_exists:
return project_exists[0].id
def get_user_id(self, gitlab_user): def get_user_id(self, gitlab_user):
user_exists = self._gitlab.users.list(username=gitlab_user) user_exists = self._gitlab.users.list(username=gitlab_user)