ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

win_updates: handle if module failed to run (#38363)

Browse source
This commit is contained in:
Jordan Borean 2018-04-10 05:25:25 +10:00 • committed by GitHub
parent 988808c066
commit ccc56e138a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/plugins/action/win_updates.py
View file

@ -186,6 +186,12 @@ class ActionModule(ActionBase):
new_module_args.pop('reboot_timeout', None) new_module_args.pop('reboot_timeout', None)
result = self._run_win_updates(new_module_args, task_vars) result = self._run_win_updates(new_module_args, task_vars)
# if the module failed to run at all then changed won't be populated
# so we just return the result as is
# https://github.com/ansible/ansible/issues/38232
if result['failed']:
return result
changed = result['changed'] changed = result['changed']
updates = result.get('updates', dict()) updates = result.get('updates', dict())
filtered_updates = result.get('filtered_updates', dict()) filtered_updates = result.get('filtered_updates', dict())
@ -235,6 +241,8 @@ class ActionModule(ActionBase):
result.pop('msg', None) result.pop('msg', None)
# rerun the win_updates module after the reboot is complete # rerun the win_updates module after the reboot is complete
result = self._run_win_updates(new_module_args, task_vars) result = self._run_win_updates(new_module_args, task_vars)
if result['failed']:
return result
result_updates = result.get('updates', dict()) result_updates = result.get('updates', dict())
result_filtered_updates = result.get('filtered_updates', dict()) result_filtered_updates = result.get('filtered_updates', dict())