Test placement (#21801)

* Fix test placement and update messaging. * Add note about group selection.
2024-09-14 20:13:21 +02:00 · 2017-02-22 12:43:45 -08:00 · 2017-02-22 12:43:45 -08:00 · cba91c7f44
commit cba91c7f44
parent b5e0eb0985
10 changed files with 9 additions and 1 deletions
--- a/test/integration/targets/cloudscale_server/defaults/main.yml
+++ b/test/integration/targets/cloudscale_server/defaults/main.yml
--- a/test/integration/targets/cloudscale_server/meta/main.yml
+++ b/test/integration/targets/cloudscale_server/meta/main.yml
--- a/test/integration/targets/cloudscale_server/tasks/main.yml
+++ b/test/integration/targets/cloudscale_server/tasks/main.yml
--- a/test/integration/targets/cnos_vlan/README.md
+++ b/test/integration/targets/cnos_vlan/README.md
--- a/test/integration/targets/cnos_vlan/cnos_vlan_sample_hosts
+++ b/test/integration/targets/cnos_vlan/cnos_vlan_sample_hosts
--- a/test/integration/targets/cnos_vlan/tasks/main.yml
+++ b/test/integration/targets/cnos_vlan/tasks/main.yml
--- a/test/integration/targets/cnos_vlan/vars/main.yml
+++ b/test/integration/targets/cnos_vlan/vars/main.yml
--- a/test/integration/targets/cloudscale_server/aliases
+++ b/test/integration/targets/cloudscale_server/aliases
--- a/test/integration/targets/cnos_vlan/aliases
+++ b/test/integration/targets/cnos_vlan/aliases
--- a/test/sanity/code-smell/integration-aliases.py
+++ b/test/sanity/code-smell/integration-aliases.py
@ -46,12 +46,20 @@ def main():

        %s

-        Unless a test cannot run as part of CI, you'll want to add an appropriate CI alias, such as:
+        If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
+        then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
+        In that case, do not add an `aliases` file. Instead, just relocate the tests.
+
+        However, if you think that the tests should be able to be supported by CI, please discuss test
+        organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.
+
+        If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

        posix/ci/group1
        windows/ci/group2

        The CI groups are used to balance tests across multiple jobs to minimize test run time.
+        Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

        Aliases can also be used to express test requirements: