1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

[PR #6650/61b88974 backport][stable-7] redhat_subscription: deprecate "pool" (#6657)

redhat_subscription: deprecate "pool" (#6650)

The "pool" option is slower to use, and the regexp may expand to broader
results than wanted. Because of that, deprecate it in favour of the
"pool_ids" options (which is much better), slating it for removal in
community.general 10.0.0.

(cherry picked from commit 61b889749e)

Co-authored-by: Pino Toscano <ptoscano@redhat.com>
This commit is contained in:
patchback[bot] 2023-06-09 17:13:31 +02:00 committed by GitHub
parent fc0981f3f1
commit cae94f9d5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 3 deletions

View file

@ -0,0 +1,5 @@
deprecated_features:
- |
redhat_subscription - the ``pool`` option is deprecated in favour of the
more precise and flexible ``pool_ids`` option
(https://github.com/ansible-collections/community.general/pull/6650).

View file

@ -143,8 +143,16 @@ options:
pool: pool:
description: description:
- | - |
Specify a subscription pool name to consume. Regular expressions accepted. Use I(pool_ids) instead if Specify a subscription pool name to consume. Regular expressions accepted.
possible, as it is much faster. Mutually exclusive with I(pool_ids). Mutually exclusive with I(pool_ids).
- |
Please use I(pool_ids) instead: specifying pool IDs is much faster,
and it avoids to match new pools that become available for the
system and are not explicitly wanted. Also, this option does not
support quantities.
- |
This option is deprecated for the reasons mentioned above,
and it will be removed in community.general 10.0.0.
default: '^$' default: '^$'
type: str type: str
pool_ids: pool_ids:
@ -1091,7 +1099,11 @@ def main():
'activationkey': {'no_log': True}, 'activationkey': {'no_log': True},
'org_id': {}, 'org_id': {},
'environment': {}, 'environment': {},
'pool': {'default': '^$'}, 'pool': {
'default': '^$',
'removed_in_version': '10.0.0',
'removed_from_collection': 'community.general',
},
'pool_ids': {'default': [], 'type': 'list', 'elements': 'raw'}, 'pool_ids': {'default': [], 'type': 'list', 'elements': 'raw'},
'consumer_type': {}, 'consumer_type': {},
'consumer_name': {}, 'consumer_name': {},