ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Datadog: Mark notification_message as no_log (#1338) (#1385)

Browse source 
* Datadog: Mark notification_message as no_log

This message field is often used to page people or teams inside
an organization when a monitor goes off, by using `@` mentions.
If Ansible is configured to use Datadog's callback plugin [1], an
unwanted interaction would happen: 
When a monitor fails to create, the callback sends an error event
to Datadog which contains all the task's loggable fields in it.
If the message field contains `@` mentions, this event would page
the people on them.

[1] https://github.com/DataDog/ansible-datadog-callback

* Add changelog fragment

* Update changelogs/fragments/1338-datadog-mark-notification_message-no_log.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit e73451f09e)

Co-authored-by: Albert Vaca Cintora <albertvaka@gmail.com>
This commit is contained in:
patchback[bot] 2020-11-25 08:01:17 +01:00 committed by GitHub
parent 999620c789
commit b99586e26a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/1338-datadog-mark-notification_message-no_log.yml Normal file
View file

@ -0,0 +1,3 @@
---
minor_changes:
- datadog - mark ``notification_message`` as ``no_log`` (https://github.com/ansible-collections/community.general/pull/1338).

2
plugins/modules/monitoring/datadog/datadog_monitor.py
View file

@ -211,7 +211,7 @@ def main():
type=dict(required=False, choices=['metric alert', 'service check', 'event alert', 'process alert', 'log alert']), type=dict(required=False, choices=['metric alert', 'service check', 'event alert', 'process alert', 'log alert']),
name=dict(required=True), name=dict(required=True),
query=dict(required=False), query=dict(required=False),
notification_message=dict(required=False, default=None, aliases=['message'], notification_message=dict(required=False, no_log=True, default=None, aliases=['message'],
deprecated_aliases=[dict(name='message', version='3.0.0', deprecated_aliases=[dict(name='message', version='3.0.0',
collection_name='community.general')]), # was Ansible 2.14 collection_name='community.general')]), # was Ansible 2.14
silenced=dict(required=False, default=None, type='dict'), silenced=dict(required=False, default=None, type='dict'),