ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

use the is_changed? paradigm, following example from other modules

Browse source
This commit is contained in:
yaacov 2017-09-25 15:53:40 +03:00 committed by René Moser
parent bf780c709d
commit b70845bb40
1 changed files with 34 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
lib/ansible/modules/remote_management/manageiq/manageiq_tags.py
View file

@ -156,27 +156,8 @@ class ManageIQTags(object):
tags_set = set([tag['name'] for tag in tags]) tags_set = set([tag['name'] for tag in tags])
return tags_set return tags_set
def post_tags(self, tags, action): def tags_to_update(self, tags, action):
""" Post the tags for the resource using ManageIQ rest api """ Create a list of tags we need to update in ManageIQ.
"""
url = '{resource_url}/tags'.format(resource_url=self.resource_url)
try:
response = self.client.post(url, action=action, resources=tags)
except Exception as e:
msg = "Failed to {action} tag: {error}".format(
action=action,
error=e)
self.module.fail_json(msg=msg)
for result in response['results']:
if not result['success']:
msg = "Failed to {action}: {message}".format(
action=action,
message=result['message'])
self.module.fail_json(msg=msg)
def assign_or_unassign_tags(self, tags, action):
""" Assign or unassign the tag on a manageiq resource.
Returns: Returns:
Whether or not a change took place and a message describing the Whether or not a change took place and a message describing the
@ -192,12 +173,37 @@ class ManageIQTags(object):
elif (not assigned) and action == 'assign': elif (not assigned) and action == 'assign':
tags_to_post.append(tag) tags_to_post.append(tag)
return tags_to_post
def assign_or_unassign_tags(self, tags, action):
""" Perform assign/unassign action
"""
# get a list of tags needed to be changed
tags_to_post = self.tags_to_update(tags, action)
if not tags_to_post: if not tags_to_post:
return dict( return dict(
changed=False, changed=False,
msg="Tags already {action}ed, nothing to do".format(action=action)) msg="Tags already {action}ed, nothing to do".format(action=action))
else:
self.post_tags(tags_to_post, action) # try to assign or unassign tags to resource
url = '{resource_url}/tags'.format(resource_url=self.resource_url)
try:
response = self.client.post(url, action=action, resources=tags)
except Exception as e:
msg = "Failed to {action} tag: {error}".format(
action=action,
error=e)
self.module.fail_json(msg=msg)
# check all entities in resoult to be successfull
for result in response['results']:
if not result['success']:
msg = "Failed to {action}: {message}".format(
action=action,
message=result['message'])
self.module.fail_json(msg=msg)
# successfully changed all needed tags
return dict( return dict(
changed=True, changed=True,
msg="Successfully {action}ed tags".format(action=action)) msg="Successfully {action}ed tags".format(action=action))
@ -228,17 +234,14 @@ def main():
action = actions[state] action = actions[state]
resource_type = manageiq_entities()[resource_type_key] resource_type = manageiq_entities()[resource_type_key]
# create the manageiq object
manageiq = ManageIQ(module) manageiq = ManageIQ(module)
# query resource id, # query resource id, fail if resource does not exist
# fail if resource does not exist
resource_id = query_resource_id(manageiq, resource_type, resource_name) resource_id = query_resource_id(manageiq, resource_type, resource_name)
# create the manageiq tag object
manageiq_tags = ManageIQTags(manageiq, resource_type, resource_id) manageiq_tags = ManageIQTags(manageiq, resource_type, resource_id)
# run action # assign or unassign the tags
res_args = manageiq_tags.assign_or_unassign_tags(tags, action) res_args = manageiq_tags.assign_or_unassign_tags(tags, action)
module.exit_json(**res_args) module.exit_json(**res_args)