ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix: GitLab API searches always return first found match (#3400)

Browse source 
* fix: return correct group id
match only full_path or name

* chore: add changelog fragment

* fix: indentation multiple of four

* refactor: use two loops

* fix: typo of group id

* fix: changelog fragment
This commit is contained in:
Chris Frage 2021-09-26 18:59:39 +02:00 committed by GitHub
parent 43a9f09a17
commit b6b7601615
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/3400-fix-gitLab-api-searches-always-return-first-found-match-3386.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- gitlab_group_members - ``get_group_id`` return the group ID by matching ``full_path``, ``path`` or ``name`` (https://github.com/ansible-collections/community.general/pull/3400).

10
plugins/modules/source_control/gitlab/gitlab_group_members.py
View file

@ -179,9 +179,13 @@ class GitLabGroup(object):
# get group id if group exists # get group id if group exists
def get_group_id(self, gitlab_group): def get_group_id(self, gitlab_group):
group_exists = self._gitlab.groups.list(search=gitlab_group) groups = self._gitlab.groups.list(search=gitlab_group)
if group_exists: for group in groups:
return group_exists[0].id if group.full_path == gitlab_group:
return group.id
for group in groups:
if group.path == gitlab_group or group.name == gitlab_group:
return group.id
# get all members in a group # get all members in a group
def get_members_in_a_group(self, gitlab_group_id): def get_members_in_a_group(self, gitlab_group_id):