ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

one more bug fix for ansible-connection (#20707)

Browse source 
The connection instance will now return a meaningful error if the
connection property returns False
This commit is contained in:
Peter Sprygada 2017-01-26 13:59:57 -05:00 committed by GitHub
parent 8c3b915721
commit b4d75f41f5
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bin/ansible-connection
View file

@ -122,7 +122,7 @@ class Server():
self.conn = connection_loader.get(play_context.connection, play_context, sys.stdin) self.conn = connection_loader.get(play_context.connection, play_context, sys.stdin)
self.conn._connect() self.conn._connect()
if not self.conn.connected: if not self.conn.connected:
raise AnsibleConnectionFailure(err) raise AnsibleConnectionFailure('unable to connect to remote host')
self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
self.socket.bind(path) self.socket.bind(path)
@ -283,8 +283,6 @@ def main():
if pid == 0: if pid == 0:
try: try:
server = Server(sf_path, pc) server = Server(sf_path, pc)
except AnsibleConnectionFailure as exc:
log(str(exc), pc.remote_addr)
except Exception as exc: except Exception as exc:
log(traceback.format_exc(), pc.remote_addr) log(traceback.format_exc(), pc.remote_addr)
fcntl.lockf(lock_fd, fcntl.LOCK_UN) fcntl.lockf(lock_fd, fcntl.LOCK_UN)