From b31de003bd7eda3aae70ed9bd0aad2399e1799cf Mon Sep 17 00:00:00 2001 From: Amin Vakil Date: Sun, 12 Jul 2020 02:52:15 +0430 Subject: [PATCH] Reduce ignored files sanity tests (#639) * Remove all files ignores to see errors * Fix * Revert archive.py as its change should be discussed in another PR * Ignore archive.py * Revert xml * Fix --- plugins/modules/files/iso_extract.py | 3 ++- plugins/modules/files/read_csv.py | 3 ++- tests/sanity/ignore-2.10.txt | 2 -- tests/sanity/ignore-2.11.txt | 2 -- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/modules/files/iso_extract.py b/plugins/modules/files/iso_extract.py index 8efd8bc00e..f95b7483ba 100644 --- a/plugins/modules/files/iso_extract.py +++ b/plugins/modules/files/iso_extract.py @@ -46,6 +46,7 @@ options: - A list of files to extract from the image. - Extracting directories does not work. type: list + elements: str required: yes force: description: @@ -99,7 +100,7 @@ def main(): argument_spec=dict( image=dict(type='path', required=True, aliases=['path', 'src']), dest=dict(type='path', required=True), - files=dict(type='list', required=True), + files=dict(type='list', elements='str', required=True), force=dict(type='bool', default=True, aliases=['thirsty']), executable=dict(type='path'), # No default on purpose ), diff --git a/plugins/modules/files/read_csv.py b/plugins/modules/files/read_csv.py index 45a3641c5b..f8d73691d3 100644 --- a/plugins/modules/files/read_csv.py +++ b/plugins/modules/files/read_csv.py @@ -39,6 +39,7 @@ options: - A list of field names for every column. - This is needed if the CSV does not have a header. type: list + elements: str unique: description: - Whether the C(key) used is expected to be unique. @@ -164,7 +165,7 @@ def main(): path=dict(type='path', required=True, aliases=['filename']), dialect=dict(type='str', default='excel'), key=dict(type='str'), - fieldnames=dict(type='list'), + fieldnames=dict(type='list', elements='str'), unique=dict(type='bool', default=True), delimiter=dict(type='str'), skipinitialspace=dict(type='bool'), diff --git a/tests/sanity/ignore-2.10.txt b/tests/sanity/ignore-2.10.txt index 525fc58409..ae803d43fa 100644 --- a/tests/sanity/ignore-2.10.txt +++ b/tests/sanity/ignore-2.10.txt @@ -648,8 +648,6 @@ plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-p plugins/modules/files/archive.py use-argspec-type-path # fix needed plugins/modules/files/archive.py validate-modules:parameter-list-no-elements plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec -plugins/modules/files/iso_extract.py validate-modules:parameter-list-no-elements -plugins/modules/files/read_csv.py validate-modules:parameter-list-no-elements plugins/modules/files/xml.py validate-modules:doc-required-mismatch plugins/modules/files/xml.py validate-modules:parameter-list-no-elements plugins/modules/identity/ipa/ipa_hbacrule.py validate-modules:doc-elements-mismatch diff --git a/tests/sanity/ignore-2.11.txt b/tests/sanity/ignore-2.11.txt index 525fc58409..ae803d43fa 100644 --- a/tests/sanity/ignore-2.11.txt +++ b/tests/sanity/ignore-2.11.txt @@ -648,8 +648,6 @@ plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-p plugins/modules/files/archive.py use-argspec-type-path # fix needed plugins/modules/files/archive.py validate-modules:parameter-list-no-elements plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec -plugins/modules/files/iso_extract.py validate-modules:parameter-list-no-elements -plugins/modules/files/read_csv.py validate-modules:parameter-list-no-elements plugins/modules/files/xml.py validate-modules:doc-required-mismatch plugins/modules/files/xml.py validate-modules:parameter-list-no-elements plugins/modules/identity/ipa/ipa_hbacrule.py validate-modules:doc-elements-mismatch