From b0cbef394fafc2ad718fae224a4f9400f30d2890 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Sat, 13 Mar 2021 17:37:30 +0100 Subject: [PATCH] Add missing no_log values. (#2018) --- changelogs/fragments/missing-no_log-again.yml | 3 +++ plugins/modules/storage/netapp/na_cdot_user.py | 2 +- plugins/modules/storage/netapp/sf_account_manager.py | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/missing-no_log-again.yml diff --git a/changelogs/fragments/missing-no_log-again.yml b/changelogs/fragments/missing-no_log-again.yml new file mode 100644 index 0000000000..a555c85ed7 --- /dev/null +++ b/changelogs/fragments/missing-no_log-again.yml @@ -0,0 +1,3 @@ +security_fixes: +- "na_cdot_user - mark the ``set_password`` parameter as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018)." +- "sf_account_manager - mark the ``initiator_secret`` and ``target_secret`` parameters as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018)." diff --git a/plugins/modules/storage/netapp/na_cdot_user.py b/plugins/modules/storage/netapp/na_cdot_user.py index 626e0aa04c..96ee86c35c 100644 --- a/plugins/modules/storage/netapp/na_cdot_user.py +++ b/plugins/modules/storage/netapp/na_cdot_user.py @@ -127,7 +127,7 @@ class NetAppCDOTUser(object): choices=['community', 'password', 'publickey', 'domain', 'nsswitch', 'usm']), - set_password=dict(required=False, type='str', default=None), + set_password=dict(required=False, type='str', default=None, no_log=True), role_name=dict(required=False, type='str'), vserver=dict(required=True, type='str'), diff --git a/plugins/modules/storage/netapp/sf_account_manager.py b/plugins/modules/storage/netapp/sf_account_manager.py index 58c6962b25..a365e4e3fb 100644 --- a/plugins/modules/storage/netapp/sf_account_manager.py +++ b/plugins/modules/storage/netapp/sf_account_manager.py @@ -115,8 +115,8 @@ class SolidFireAccount(object): account_id=dict(required=False, type='int', default=None), new_name=dict(required=False, type='str', default=None), - initiator_secret=dict(required=False, type='str'), - target_secret=dict(required=False, type='str'), + initiator_secret=dict(required=False, type='str', no_log=True), + target_secret=dict(required=False, type='str', no_log=True), attributes=dict(required=False, type='dict'), status=dict(required=False, type='str'), ))