postgresql_set: add trust_input parameter (#302)

* postgresql_set: add trust_input parameter

* add changelog fragment

* fix CI

changelogs/fragments/302-postgresql_set_add_trust_input_parameter.yml

@@ -0,0 +1,2 @@
+minor_changes:
+- postgresql_set - add the ``trust_input`` parameter (https://github.com/ansible-collections/community.general/pull/302).

plugins/modules/database/postgresql/postgresql_set.py

@@ -59,6 +59,12 @@ options:
     type: str
     aliases:
     - login_db
+  trust_input:
+    description:
+    - If C(no), check whether values of parameters are potentially dangerous.
+    - It does make sense to use C(yes) only when SQL injections are possible.
+    type: bool
+    default: yes
 notes:
 - Supported version of PostgreSQL is 9.4 and later.
 - Pay attention, change setting with 'postmaster' context can return changed is true
@@ -166,6 +172,9 @@ except Exception:
 from copy import deepcopy
 
 from ansible.module_utils.basic import AnsibleModule
+from ansible_collections.community.general.plugins.module_utils.database import (
+    check_input,
+)
 from ansible_collections.community.general.plugins.module_utils.postgres import (
     connect_to_db,
     get_conn_params,
@@ -287,15 +296,22 @@ def main():
         value=dict(type='str'),
         reset=dict(type='bool'),
         session_role=dict(type='str'),
+        trust_input=dict(type='bool', default=True),
     )
     module = AnsibleModule(
         argument_spec=argument_spec,
         supports_check_mode=True,
     )
 
-    name = module.params["name"]
+    name = module.params['name']
-    value = module.params["value"]
+    value = module.params['value']
-    reset = module.params["reset"]
+    reset = module.params['reset']
+    session_role = module.params['session_role']
+    trust_input = module.params['trust_input']
+
+    if not trust_input:
+        # Check input for potentially dangerous elements:
+        check_input(module, name, value, session_role)
 
     # Allow to pass values like 1mb instead of 1MB, etc:
     if value:

tests/integration/targets/postgresql_set/tasks/postgresql_set_initial.yml

@@ -288,6 +288,7 @@
     <<: *task_parameters
     postgresql_set:
       <<: *pg_parameters
+      trust_input: yes
       name: archive_command
       value: 'test ! -f /mnt/postgres/mb/%f && cp %p /mnt/postgres/mb/%f'
 
@@ -302,3 +303,21 @@
   - assert:
       that:
       - result.query_result.0.reset_val == "test ! -f /mnt/postgres/mb/%f && cp %p /mnt/postgres/mb/%f"
+
+  #############################
+  # Check trust_input parameter
+  - name: postgresql_set - check trust_input
+    <<: *task_parameters
+    postgresql_set:
+      <<: *pg_parameters
+      name: shared_buffers
+      value: 111MB
+      trust_input: no
+      session_role: 'curious.anonymous"; SELECT * FROM information_schema.tables; --'
+    register: result
+    ignore_errors: yes
+
+  - assert:
+      that:
+      - result is failed
+      - result.msg is search('is potentially dangerous')