ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Add warning for json import. Fixes #2

Browse source
This commit is contained in:
Matt Martz 2015-05-18 15:41:16 -05:00 committed by John Barker
parent 074e4ad47f
commit af6dde6eae
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ansible_testing/modules.py
View file

@ -103,6 +103,15 @@ class ModuleValidator(Validator):
if not self.text.startswith('#!/usr/bin/python'): if not self.text.startswith('#!/usr/bin/python'):
self.errors.append('Interpreter line is not "#!/usr/bin/python"') self.errors.append('Interpreter line is not "#!/usr/bin/python"')
def _find_json_import(self):
for child in self.ast.body:
if isinstance(child, ast.Import):
for name in child.names:
if name.name == 'json':
self.warnings.append('JSON import found, '
'already provided by '
'ansible.module_utils.basic')
def _find_module_utils(self): def _find_module_utils(self):
linenos = [] linenos = []
for child in self.ast.body: for child in self.ast.body:
@ -213,6 +222,7 @@ class ModuleValidator(Validator):
if not self._just_docs(): if not self._just_docs():
self._check_interpreter() self._check_interpreter()
self._find_json_import()
module_utils = self._find_module_utils() module_utils = self._find_module_utils()
main = self._find_main_call() main = self._find_main_call()
for mu in module_utils: for mu in module_utils: