ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix min_size reference where type is None (#53669)

Browse source
This commit is contained in:
Jason Witkowski 2019-03-12 21:31:03 -04:00 • committed by ansibot
parent 33939f7fe8
commit acdb4c3ede
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/53669-ec2_asg_fix_race_condition.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- ec2_asg - Fix scenario where min_size can end up passing None type to boto

2
lib/ansible/modules/cloud/amazon/ec2_asg.py
View file

@ -1488,6 +1488,8 @@ def terminate_batch(connection, replace_instances, initial_instances, leftovers=
if num_new_inst_needed == 0: if num_new_inst_needed == 0:
decrement_capacity = True decrement_capacity = True
if as_group['MinSize'] != min_size: if as_group['MinSize'] != min_size:
if min_size is None:
min_size = as_group['MinSize']
updated_params = dict(AutoScalingGroupName=as_group['AutoScalingGroupName'], MinSize=min_size) updated_params = dict(AutoScalingGroupName=as_group['AutoScalingGroupName'], MinSize=min_size)
update_asg(connection, **updated_params) update_asg(connection, **updated_params)
module.debug("Updating minimum size back to original of %s" % min_size) module.debug("Updating minimum size back to original of %s" % min_size)