Replace missing default favicon with docs.ansible.com favicon (#5928)

* replace missing default favicon with docs.ansible.com

* create changelog fragment for PR 5928

* move changelog fragment

* fix parameter description

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix parameter description

Co-authored-by: Felix Fontein <felix@fontein.de>

* add affected modules in changelog fragment

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Lars Krahl <lkr@mms-dresden.de>
Co-authored-by: Felix Fontein <felix@fontein.de>

changelogs/fragments/5928-fix-favicon-url.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (https://github.com/ansible-collections/community.general/pull/5928).

plugins/modules/mattermost.py

@@ -60,8 +60,8 @@ options:
   icon_url:
     type: str
     description:
-      - Url for the message sender's icon.
+      - URL for the message sender's icon.
-    default: https://www.ansible.com/favicon.ico
+    default: https://docs.ansible.com/favicon.ico
   validate_certs:
     description:
       - If C(false), SSL certificates will not be validated. This should only be used
@@ -127,7 +127,7 @@ def main():
             text=dict(type='str'),
             channel=dict(type='str', default=None),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             validate_certs=dict(default=True, type='bool'),
             attachments=dict(type='list', elements='dict'),
         ),

plugins/modules/rocketchat.py

@@ -58,7 +58,7 @@ options:
     type: str
     description:
       - URL for the message sender's icon.
-    default: "https://www.ansible.com/favicon.ico"
+    default: "https://docs.ansible.com/favicon.ico"
   icon_emoji:
     type: str
     description:
@@ -212,7 +212,7 @@ def main():
             msg=dict(type='str', required=False),
             channel=dict(type='str'),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             icon_emoji=dict(type='str'),
             link_names=dict(type='int', default=1, choices=[0, 1]),
             validate_certs=dict(default=True, type='bool'),

plugins/modules/slack.py

@@ -81,8 +81,8 @@ options:
   icon_url:
     type: str
     description:
-      - Url for the message sender's icon (default C(https://www.ansible.com/favicon.ico))
+      - URL for the message sender's icon (default C(https://docs.ansible.com/favicon.ico))
-    default: https://www.ansible.com/favicon.ico
+    default: https://docs.ansible.com/favicon.ico
   icon_emoji:
     type: str
     description:
@@ -439,7 +439,7 @@ def main():
             channel=dict(type='str'),
             thread_id=dict(type='str'),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             icon_emoji=dict(type='str'),
             link_names=dict(type='int', default=1, choices=[0, 1]),
             parse=dict(type='str', choices=['none', 'full']),

tests/unit/plugins/modules/test_slack.py

@@ -142,7 +142,7 @@ class TestSlackModule(ModuleTestCase):
                 },
                 'accessory': {
                     'type': 'image',
-                    'image_url': 'https://www.ansible.com/favicon.ico',
+                    'image_url': 'https://docs.ansible.com/favicon.ico',
                     'alt_text': 'test'
                 }
             }, {