From a46c55b2dd9aecc92203e3f2128c3ba4e2df2ff4 Mon Sep 17 00:00:00 2001 From: Ondra Machacek Date: Mon, 20 Mar 2017 14:39:16 +0100 Subject: [PATCH] cloud: ovirt: Add sparsify option to ovirt_disks (#22560) This patch fixes: https://github.com/ansible/ansible/issues/22348 --- lib/ansible/modules/cloud/ovirt/ovirt_disks.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_disks.py b/lib/ansible/modules/cloud/ovirt/ovirt_disks.py index 3169b28923..2bac0e8907 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_disks.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_disks.py @@ -124,6 +124,15 @@ options: - "C(username) - CHAP Username to be used to access storage server. Used by iSCSI." - "C(password) - CHAP Password of the user to be used to access storage server. Used by iSCSI." - "C(storage_type) - Storage type either I(fcp) or I(iscsi)." + sparsify: + description: + - "I(True) if the disk should be sparsified." + - "Sparsification frees space in the disk image that is not used by + its filesystem. As a result, the image will occupy less space on + the storage." + - "Note that this parameter isn't idempotent, as it's not possible + to check if the disk should be or should not be sparsified." + version_added: "2.4" extends_documentation_fragment: ovirt ''' @@ -510,6 +519,7 @@ def main(): download_image_path=dict(default=None), upload_image_path=dict(default=None, aliases=['image_path']), force=dict(default=False, type='bool'), + sparsify=dict(default=None, type='bool'), ) module = AnsibleModule( argument_spec=argument_spec, @@ -558,6 +568,13 @@ def main(): ): downloaded = download_disk_image(connection, module) ret['changed'] = ret['changed'] or downloaded + + # Disk sparsify: + ret = disks_module.action( + action='sparsify', + action_condition=lambda d: module.params['sparsify'], + wait_condition=lambda d: d.status == otypes.DiskStatus.OK, + ) elif state == 'absent': ret = disks_module.remove()