ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Redfish: perform manager network interface configuration even if property is missing (#3582) (#3590)

Browse source 
* Redfish: perform manager network interface configuration even if property is missing

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update changelogs/fragments/3404-redfish_utils-skip-manager-network-check.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6580e7559b)

Co-authored-by: Mike Raineri <michael.raineri@dell.com>
This commit is contained in:
patchback[bot] 2021-10-20 17:49:01 +02:00 committed by GitHub
parent 56bbbca2ce
commit a3c597425d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/3404-redfish_utils-skip-manager-network-check.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- redfish_utils module utils - if a manager network property is not specified in the service, attempt to change the requested settings (https://github.com/ansible-collections/community.general/issues/3404/).

8
plugins/module_utils/redfish_utils.py
View file

@ -2740,7 +2740,9 @@ class RedfishUtils(object):
if isinstance(set_value, dict): if isinstance(set_value, dict):
for subprop in payload[property].keys(): for subprop in payload[property].keys():
if subprop not in target_ethernet_current_setting[property]: if subprop not in target_ethernet_current_setting[property]:
return {'ret': False, 'msg': "Sub-property %s in nic_config is invalid" % subprop} # Not configured already; need to apply the request
need_change = True
break
sub_set_value = payload[property][subprop] sub_set_value = payload[property][subprop]
sub_cur_value = target_ethernet_current_setting[property][subprop] sub_cur_value = target_ethernet_current_setting[property][subprop]
if sub_set_value != sub_cur_value: if sub_set_value != sub_cur_value:
@ -2754,7 +2756,9 @@ class RedfishUtils(object):
for i in range(len(set_value)): for i in range(len(set_value)):
for subprop in payload[property][i].keys(): for subprop in payload[property][i].keys():
if subprop not in target_ethernet_current_setting[property][i]: if subprop not in target_ethernet_current_setting[property][i]:
return {'ret': False, 'msg': "Sub-property %s in nic_config is invalid" % subprop} # Not configured already; need to apply the request
need_change = True
break
sub_set_value = payload[property][i][subprop] sub_set_value = payload[property][i][subprop]
sub_cur_value = target_ethernet_current_setting[property][i][subprop] sub_cur_value = target_ethernet_current_setting[property][i][subprop]
if sub_set_value != sub_cur_value: if sub_set_value != sub_cur_value: