From 9f4fd4c899fcba973da67077fb21f7d275014227 Mon Sep 17 00:00:00 2001 From: christophemorio <49184206+christophemorio@users.noreply.github.com> Date: Wed, 13 Jan 2021 07:49:00 +0100 Subject: [PATCH] init_reconfigure fails on module cloud/misc/terraform.py (#1620) * fix reconfigure option If `init_reconfigure` is true, the init fails because it is run as: `terraform init -input=false - r e c o n f i g u r e` * changelog fragment * typo Co-authored-by: Felix Fontein Co-authored-by: Felix Fontein --- changelogs/fragments/1620-terraform_init_reconfigure_fix.yml | 2 ++ plugins/modules/cloud/misc/terraform.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/1620-terraform_init_reconfigure_fix.yml diff --git a/changelogs/fragments/1620-terraform_init_reconfigure_fix.yml b/changelogs/fragments/1620-terraform_init_reconfigure_fix.yml new file mode 100644 index 0000000000..9b8bab8f49 --- /dev/null +++ b/changelogs/fragments/1620-terraform_init_reconfigure_fix.yml @@ -0,0 +1,2 @@ +bugfixes: +- terraform - fix ``init_reconfigure`` option for proper CLI args (https://github.com/ansible-collections/community.general/pull/1620). diff --git a/plugins/modules/cloud/misc/terraform.py b/plugins/modules/cloud/misc/terraform.py index e7e3ae898f..9e8834821c 100644 --- a/plugins/modules/cloud/misc/terraform.py +++ b/plugins/modules/cloud/misc/terraform.py @@ -219,7 +219,7 @@ def init_plugins(bin_path, project_path, backend_config, backend_config_files, i for f in backend_config_files: command.extend(['-backend-config', f]) if init_reconfigure: - command.extend('-reconfigure') + command.extend(['-reconfigure']) rc, out, err = module.run_command(command, cwd=project_path) if rc != 0: module.fail_json(msg="Failed to initialize Terraform modules:\r\n{0}".format(err))