From 9ddf8b8ee5c4e23073f8f564785f4a9d271e8ece Mon Sep 17 00:00:00 2001 From: Ivan Bojer Date: Fri, 2 Feb 2018 04:35:02 -0800 Subject: [PATCH] remove panos_security_policy (#34433) * remove panos_security_policy * added depreciation notice * - deprecation notice * properly document deprecated module * merge changes * merge changes * parser expects srt for deprecations attributes --- CHANGELOG.md | 2 ++ docs/docsite/rst/porting_guide_2.5.rst | 1 + lib/ansible/modules/network/panos/_panos_security_policy.py | 6 +++--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5134736724..4df306d463 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ Ansible Changes By Release * nxos_portchannel module is deprecated in Ansible 2.5. Use nxos_linkagg module instead. * nxos_switchport module is deprecated in Ansible 2.5. Use nxos_l2_interface module instead. * ec2_ami_find has been deprecated, use ec2_ami_facts. +* panos_security_policy: Use panos_security_rule - the old module uses deprecated API calls See [Porting Guide](http://docs.ansible.com/ansible/devel/porting_guides.html) for more information @@ -72,6 +73,7 @@ See [Porting Guide](http://docs.ansible.com/ansible/devel/porting_guides.html) f * ec2_vpc. * ec2_ami_search, use ec2_ami_facts instead. * nxos_mtu, use nxos_system's `system_mtu` option. To specify an interfaces MTU use nxos_interface. + https://github.com/ansible/ansible/issues/29387 ### New Plugins diff --git a/docs/docsite/rst/porting_guide_2.5.rst b/docs/docsite/rst/porting_guide_2.5.rst index 36c94e5b24..bd2dc9bc67 100644 --- a/docs/docsite/rst/porting_guide_2.5.rst +++ b/docs/docsite/rst/porting_guide_2.5.rst @@ -140,6 +140,7 @@ The following modules will be removed in Ansible 2.9. Please update update your * :ref:`nxos_ip_interface ` use :ref:`nxos_l3_interface ` instead. * :ref:`nxos_portchannel ` use :ref:`nxos_linkagg ` instead. * :ref:`nxos_switchport ` use :ref:`nxos_l2_interface ` instead. +* :ref:`panos_security_policy ` use :ref:`panos_security_rule ` instead. Noteworthy module changes ------------------------- diff --git a/lib/ansible/modules/network/panos/_panos_security_policy.py b/lib/ansible/modules/network/panos/_panos_security_policy.py index 34fb151cbe..68f5eb48d7 100644 --- a/lib/ansible/modules/network/panos/_panos_security_policy.py +++ b/lib/ansible/modules/network/panos/_panos_security_policy.py @@ -36,9 +36,9 @@ description: author: "Ivan Bojer (@ivanbojer)" version_added: "2.3" deprecated: - removed_in: "2.8" - why: Renamed to M(panos_security_rule) in order to align with API calls and UI object references, which also has extra support for PanDevice SDK. - alternative: Use M(panos_security_rule) instead. + alternative: Use M(panos_security_rule) instead. + removed_in: '2.9' + why: This module depended on outdated and old SDK. In 2.4 use M(panos_security_rule) instead. requirements: - pan-python can be obtained from PyPi U(https://pypi.python.org/pypi/pan-python) - pandevice can be obtained from PyPi U(https://pypi.python.org/pypi/pandevice)