ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Better handling of base64-encoded values in xattr module (#3675) (#3678)

Browse source 
* Fix exception in xattr module when existing extended attribute's value contains non-printable characters and the base64-encoded string contains a '=' sign

* Added changelog fragment for #3675

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 2f0ae0408d)

Co-authored-by: sc-anssi <sc-anssi@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2021-11-09 06:29:09 +01:00 committed by GitHub
parent 01b2c48161
commit 9bd2d1ec90
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/3675-xattr-handle-base64-values.yml Normal file
View file

@ -0,0 +1,3 @@
bugfixes:
- xattr - fix exception caused by ``_run_xattr()`` raising a ``ValueError``
due to a mishandling of base64-encoded value (https://github.com/ansible-collections/community.general/issues/3673).

2
plugins/modules/files/xattr.py
View file

@ -158,7 +158,7 @@ def _run_xattr(module, cmd, check_rc=True):
if line.startswith('#') or line == '': if line.startswith('#') or line == '':
pass pass
elif '=' in line: elif '=' in line:
(key, val) = line.split('=') (key, val) = line.split('=', 1)
result[key] = val.strip('"') result[key] = val.strip('"')
else: else:
result[line] = '' result[line] = ''