ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix a process execution using lxc connection plugin on Python3.

Browse source 
python2-lxc module needs bytes, on the other hand python3-lxc requires text.
To solve such incompatibility, use to_native other than to_bytes.
This fixes #41060.
This commit is contained in:
toshi_pp 2018-06-09 16:49:29 +09:00 committed by Toshio Kuratomi
parent 204fc7becf
commit 9a4ad89ec5
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/ansible/plugins/connection/lxc.py
View file

@ -45,7 +45,7 @@ except ImportError:
from ansible import constants as C from ansible import constants as C
from ansible import errors from ansible import errors
from ansible.module_utils._text import to_bytes from ansible.module_utils._text import to_bytes, to_native
from ansible.plugins.connection import ConnectionBase from ansible.plugins.connection import ConnectionBase
@ -116,8 +116,9 @@ class Connection(ConnectionBase):
''' run a command on the chroot ''' ''' run a command on the chroot '''
super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable) super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)
executable = to_bytes(self._play_context.executable, errors='surrogate_or_strict') # python2-lxc needs bytes. python3-lxc needs text.
local_cmd = [executable, '-c', to_bytes(cmd, errors='surrogate_or_strict')] executable = to_native(self._play_context.executable, errors='surrogate_or_strict')
local_cmd = [executable, '-c', to_native(cmd, errors='surrogate_or_strict')]
read_stdout, write_stdout = None, None read_stdout, write_stdout = None, None
read_stderr, write_stderr = None, None read_stderr, write_stderr = None, None