mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
VMware: Avoid misleading PyVmomi error if requests import fails (#47313)
* Avoid misleading PyVmomi error if requests import fails Requests is imported by the VMware module_utils as an external dependency; however, because it is in a try/catch block containing the imports for PyVmomi, if requests fails to import properly, Ansible will instead complain about PyVmomi not being installed. By moving the import outside of the try/catch block, if requests fails to import, an error like the following will be returned: ImportError: No module named requests This should result in less confusion. * catch requests ImportError
This commit is contained in:
parent
c649d0ea32
commit
99ee30768a
1 changed files with 9 additions and 0 deletions
|
@ -15,6 +15,11 @@ from random import randint
|
|||
try:
|
||||
# requests is required for exception handling of the ConnectionError
|
||||
import requests
|
||||
HAS_REQUESTS = True
|
||||
except ImportError:
|
||||
HAS_REQUESTS = False
|
||||
|
||||
try:
|
||||
from pyVim import connect
|
||||
from pyVmomi import vim, vmodl
|
||||
HAS_PYVMOMI = True
|
||||
|
@ -777,6 +782,10 @@ class PyVmomi(object):
|
|||
"""
|
||||
Constructor
|
||||
"""
|
||||
if not HAS_REQUESTS:
|
||||
self.module.fail_json(msg="Unable to find 'requests' Python library which is required."
|
||||
" Please install using 'pip install requests'")
|
||||
|
||||
if not HAS_PYVMOMI:
|
||||
module.fail_json(msg='PyVmomi Python module required. Install using "pip install PyVmomi"')
|
||||
|
||||
|
|
Loading…
Reference in a new issue