ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

disable new win_get_url test

Browse source 
* invalid drive letter breaks new Powershell path validation (this is a separate issue that needs to be solved)
* test also exposes a minor bug in win_get_url where a nonexistent directory in the root of a drive that exists passes the "does the parent dir exist" check and causes DownloadFile to bomb (this should be fixed by dag's rewrite of win_get_url in https://github.com/ansible/ansible/pull/26612)
This commit is contained in:
Matt Davis 2017-07-10 11:51:46 -07:00
parent 2e6ff97d06
commit 961af6d9e2
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
test/integration/targets/win_get_url/tasks/main.yml
View file

@ -121,15 +121,15 @@
- "win_get_url_result_dir_path_urlpath|changed"
- "win_get_url_result_dir_path_urlpath.win_get_url.actual_dest==expected_dest_path"
- name: since 2.4 check you get a helpful message if the parent folder of the dest doesnt exist
win_get_url:
url: "{{test_win_get_url_link}}"
dest: "{{test_win_get_url_invalid_path_dir}}"
register: win_get_url_result_invalid_dest
ignore_errors: true
- name: check if dest parent dir does not exist, module fails and you get a specific error message
assert:
that:
- "win_get_url_result_invalid_dest|failed"
- "win_get_url_result_invalid_dest.msg is search('does not exist')"
#- name: since 2.4 check you get a helpful message if the parent folder of the dest doesnt exist
# win_get_url:
# url: "{{test_win_get_url_link}}"
# dest: "{{test_win_get_url_invalid_path_dir}}"
# register: win_get_url_result_invalid_dest
# ignore_errors: true
#
#- name: check if dest parent dir does not exist, module fails and you get a specific error message
# assert:
# that:
# - "win_get_url_result_invalid_dest|failed"
# - "win_get_url_result_invalid_dest.msg is search('does not exist')"