ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

cloudflare_dns: Cleanup record update handling

Browse source
This commit is contained in:
Michael Gruener 2016-03-25 19:41:18 +01:00 committed by Matt Clay
parent 78640328cb
commit 95f270089b
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/modules/extras/network/cloudflare_dns.py
View file

@ -461,23 +461,19 @@ class CloudflareAPI(object):
# in theory this should be impossible as cloudflare does not allow # in theory this should be impossible as cloudflare does not allow
# the creation of duplicate records but lets cover it anyways # the creation of duplicate records but lets cover it anyways
if len(records) > 1: if len(records) > 1:
return records,self.changed self.module.fail_json(msg="More than one record already exists for the given attributes. That should be impossible, please open an issue!")
# record already exists, check if ttl must be updated # record already exists, check if it must be updated
if len(records) == 1: if len(records) == 1:
cur_record = records[0] cur_record = records[0]
do_update = False do_update = False
if (params['ttl'] is not None) and (cur_record['ttl'] != params['ttl'] ): if (params['ttl'] is not None) and (cur_record['ttl'] != params['ttl'] ):
cur_record['ttl'] = params['ttl']
do_update = True do_update = True
if (params['priority'] is not None) and ('priority' in cur_record) and (cur_record['priority'] != params['priority']): if (params['priority'] is not None) and ('priority' in cur_record) and (cur_record['priority'] != params['priority']):
cur_record['priority'] = params['priority']
do_update = True do_update = True
if ('data' in new_record) and ('data' in cur_record): if ('data' in new_record) and ('data' in cur_record):
if (cur_record['data'] > new_record['data']) - (cur_record['data'] < new_record['data']): if (cur_record['data'] > new_record['data']) - (cur_record['data'] < new_record['data']):
cur_record['data'] = new_record['data']
do_update = True do_update = True
if (type == 'CNAME') and (cur_record['content'] != new_record['content']): if (type == 'CNAME') and (cur_record['content'] != new_record['content']):
cur_record['content'] = new_record['content']
do_update = True do_update = True
if do_update: if do_update:
if not self.module.check_mode: if not self.module.check_mode: