ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

make debconf compare apples to apples (booleans) (#53331)

Browse source 
hope to fix #25481
This commit is contained in:
Brian Coca 2019-03-05 16:03:54 -05:00 committed by GitHub
parent 8136e2e4fe
commit 949ddb48c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/debconf_bool_fix.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- Fix how debconf handles boolean questions to accurately compare

12
lib/ansible/modules/system/debconf.py
View file

@ -87,6 +87,7 @@ EXAMPLES = r'''
name: tzdata
'''
from ansible.module_utils._text import to_text
from ansible.module_utils.basic import AnsibleModule
@ -151,8 +152,17 @@ def main():
if vtype is None or value is None:
module.fail_json(msg="when supplying a question you must supply a valid vtype and value")
if question not in prev or prev[question] != value:
# if question doesn't exist, value cannot match
if question not in prev:
changed = True
else:
# ensure we compare booleans supplied to the way debconf sees them (true/false strings)
if vtype == 'boolean':
value = to_text(value).lower()
existing = to_text(prev[question]).lower()
if value != existing:
changed = True
if changed:
if not module.check_mode: