ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

better error messasge (#42770)

Browse source 
* better error messasge
This commit is contained in:
Brian Coca 2018-07-19 12:13:09 -04:00 committed by GitHub
parent 7c318d4e30
commit 9217fbb7dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/clarify_error_message.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- Fix an atomic_move error that is 'true', but misleading. Now we show all 3 files involved and clarify what happened.

3
lib/ansible/module_utils/basic.py
View file

@ -2618,7 +2618,8 @@ class AnsibleModule(object):
if unsafe_writes and e.errno == errno.EBUSY: if unsafe_writes and e.errno == errno.EBUSY:
self._unsafe_writes(b_tmp_dest_name, b_dest) self._unsafe_writes(b_tmp_dest_name, b_dest)
else: else:
self.fail_json(msg='Unable to rename file: %s to %s: %s' % (src, dest, to_native(e)), self.fail_json(msg='Unable to make %s into to %s, failed final rename from %s: %s' %
(src, dest, b_tmp_dest_name, to_native(e)),
exception=traceback.format_exc()) exception=traceback.format_exc())
except (shutil.Error, OSError, IOError) as e: except (shutil.Error, OSError, IOError) as e:
self.fail_json(msg='Failed to replace file: %s to %s: %s' % (src, dest, to_native(e)), self.fail_json(msg='Failed to replace file: %s to %s: %s' % (src, dest, to_native(e)),