mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
make inventory warnings a bit smarter (#46284)
less annoying for common cases add comment for 'tricky' conditional
This commit is contained in:
parent
4961f003e5
commit
903cfa63cb
2 changed files with 4 additions and 2 deletions
|
@ -807,7 +807,7 @@ class CLI(with_metaclass(ABCMeta, object)):
|
||||||
no_hosts = False
|
no_hosts = False
|
||||||
if len(inventory.list_hosts()) == 0:
|
if len(inventory.list_hosts()) == 0:
|
||||||
# Empty inventory
|
# Empty inventory
|
||||||
if C.LOCALHOST_WARNING:
|
if C.LOCALHOST_WARNING and pattern not in C.LOCALHOST:
|
||||||
display.warning("provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'")
|
display.warning("provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'")
|
||||||
no_hosts = True
|
no_hosts = True
|
||||||
|
|
||||||
|
|
|
@ -289,6 +289,8 @@ class InventoryManager(object):
|
||||||
if C.INVENTORY_ANY_UNPARSED_IS_FAILED:
|
if C.INVENTORY_ANY_UNPARSED_IS_FAILED:
|
||||||
raise AnsibleError(u'Completely failed to parse inventory source %s' % (source))
|
raise AnsibleError(u'Completely failed to parse inventory source %s' % (source))
|
||||||
if not parsed:
|
if not parsed:
|
||||||
|
if source != '/etc/ansible/hosts' or os.path.exists(source):
|
||||||
|
# only warn if NOT using the default and if using it, only if the file is present
|
||||||
display.warning("Unable to parse %s as an inventory source" % source)
|
display.warning("Unable to parse %s as an inventory source" % source)
|
||||||
|
|
||||||
# clear up, jic
|
# clear up, jic
|
||||||
|
|
Loading…
Reference in a new issue