pacman: fix upgrade: yes (#4275) (#4277)

* s/sys-upgrade/sysupgrade/

* changelog fragment

* yamllint

* more fragment tweaks

(cherry picked from commit b9f62bb4ef)

Co-authored-by: Jean Raby <jean@raby.sh>

changelogs/fragments/4275-pacman-sysupgrade.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - pacman - fix ``upgrade=yes``
+    (https://github.com/ansible-collections/community.general/pull/4275, https://github.com/ansible-collections/community.general/issues/4274).

plugins/modules/packaging/os/pacman.py

@@ -410,7 +410,7 @@ class Pacman(object):
             cmd = [
                 self.pacman_path,
                 "--sync",
-                "--sys-upgrade",
+                "--sysupgrade",
                 "--quiet",
                 "--noconfirm",
             ]

tests/unit/plugins/modules/packaging/os/test_pacman.py

@@ -365,7 +365,7 @@ class TestPacman:
                 # for real
                 False,
                 {
-                    "args": ["pacman", "--sync", "--sys-upgrade", "--quiet", "--noconfirm"],
+                    "args": ["pacman", "--sync", "--sysupgrade", "--quiet", "--noconfirm"],
                     "return_value": [0, "stdout", "stderr"],
                 },
                 None,
@@ -377,7 +377,7 @@ class TestPacman:
                     "args": [
                         "pacman",
                         "--sync",
-                        "--sys-upgrade",
+                        "--sysupgrade",
                         "--quiet",
                         "--noconfirm",
                         "--some",