From 8e45b96a330f0890d006d46d4d6b1aa30cb51ce1 Mon Sep 17 00:00:00 2001 From: Till! Date: Wed, 15 Jul 2020 15:22:06 +0200 Subject: [PATCH] Update: only "warn" when restart is required (#651) * Fix: only "warn" when restart is required Motivation: my logs are flooded with "warnings" when I run roles against instances. So even though I understand for this "warning", it's a false positive when nothing needs to be done. * Update changelogs/fragments/651-fix-postgresql_set-warning.yaml Co-authored-by: Andrew Klychkov Co-authored-by: Andrew Klychkov --- changelogs/fragments/651-fix-postgresql_set-warning.yaml | 4 ++++ plugins/modules/database/postgresql/postgresql_set.py | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/651-fix-postgresql_set-warning.yaml diff --git a/changelogs/fragments/651-fix-postgresql_set-warning.yaml b/changelogs/fragments/651-fix-postgresql_set-warning.yaml new file mode 100644 index 0000000000..8369a4cef5 --- /dev/null +++ b/changelogs/fragments/651-fix-postgresql_set-warning.yaml @@ -0,0 +1,4 @@ +--- +bugfixes: + - postgresql_set - only display a warning about restarts, when + restarting is needed (https://github.com/ansible-collections/community.general/pull/651). diff --git a/plugins/modules/database/postgresql/postgresql_set.py b/plugins/modules/database/postgresql/postgresql_set.py index 346993ea69..3aaed12026 100644 --- a/plugins/modules/database/postgresql/postgresql_set.py +++ b/plugins/modules/database/postgresql/postgresql_set.py @@ -406,9 +406,6 @@ def main(): changed = param_set(cursor, module, name, boot_val, context) - if restart_required: - module.warn("Restart of PostgreSQL is required for setting %s" % name) - cursor.close() db_connection.close() @@ -439,6 +436,10 @@ def main(): kw['changed'] = changed kw['restart_required'] = restart_required + + if restart_required and changed: + module.warn("Restart of PostgreSQL is required for setting %s" % name) + module.exit_json(**kw)