From 86341f7520cfc68c4cb68b8fc7d07e1e96caa336 Mon Sep 17 00:00:00 2001 From: Ted Timmons Date: Wed, 5 Sep 2018 11:42:51 -0700 Subject: [PATCH] docfix, python-netaddr should be netaddr (#43372) "python-netaddr" is an OS package, but "netaddr" is the pypi package needed in python. Suggesting OS packages for python libs seems in bad form. I like the syntax "python's netaddr" to explain what package manager would have it. --- lib/ansible/plugins/filter/ipaddr.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ansible/plugins/filter/ipaddr.py b/lib/ansible/plugins/filter/ipaddr.py index 9087d7d759..98c6e54976 100644 --- a/lib/ansible/plugins/filter/ipaddr.py +++ b/lib/ansible/plugins/filter/ipaddr.py @@ -1080,8 +1080,8 @@ def macaddr(value, query=''): def _need_netaddr(f_name, *args, **kwargs): - raise errors.AnsibleFilterError('The %s filter requires python-netaddr be ' - 'installed on the ansible controller' % f_name) + raise errors.AnsibleFilterError("The %s filter requires python's netaddr be " + "installed on the ansible controller" % f_name) def ip4_hex(arg, delimiter=''): @@ -1120,5 +1120,5 @@ class FilterModule(object): if netaddr: return self.filter_map else: - # Need to install python-netaddr for these filters to work + # Need to install python's netaddr for these filters to work return dict((f, partial(_need_netaddr, f)) for f in self.filter_map)