From 8548690ca3c0aa0c21d0d361b8d7e77701522184 Mon Sep 17 00:00:00 2001 From: Florian Apolloner Date: Thu, 17 Sep 2015 14:24:27 +0200 Subject: [PATCH] Added a test to ensure that sudo is only used if remote and become user difer. --- test/units/plugins/action/test_action.py | 45 ++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 test/units/plugins/action/test_action.py diff --git a/test/units/plugins/action/test_action.py b/test/units/plugins/action/test_action.py new file mode 100644 index 0000000000..54fc168c43 --- /dev/null +++ b/test/units/plugins/action/test_action.py @@ -0,0 +1,45 @@ +# (c) 2015, Florian Apolloner +# +# This file is part of Ansible +# +# Ansible is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# Ansible is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Ansible. If not, see . + +# Make coding more python3-ish +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + + +from ansible.compat.tests import unittest +from ansible.compat.tests.mock import Mock +from ansible.playbook.play_context import PlayContext +from ansible.plugins.action import ActionBase + + +class TestActionBase(unittest.TestCase): + + def test_sudo_only_if_user_differs(self): + play_context = PlayContext() + action_base = ActionBase(None, None, play_context, None, None, None) + action_base._connection = Mock(exec_command=Mock(return_value=(0, '', '', ''))) + + play_context.become = True + play_context.become_user = play_context.remote_user = 'root' + play_context.make_become_cmd = Mock(return_value='CMD') + + action_base._low_level_execute_command('ECHO', '/tmp', sudoable=True) + play_context.make_become_cmd.assert_not_called() + + play_context.remote_user = 'apo' + action_base._low_level_execute_command('ECHO', '/tmp', sudoable=True) + play_context.make_become_cmd.assert_called_once_with('ECHO', executable=None)