1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

Make sure action plugin copy cleans up tmp dir

The copy action plugin creates its own tmp dir for each file that it
copies to the target machine.  However, it does not clean up the
original tmp path it was given when run() is called.  This cleans up the
tmp path before it begins looping on source files.
This commit is contained in:
Stephen Fromm 2013-12-20 14:46:44 -08:00
parent 0d4294da42
commit 833e1f6e2a

View file

@ -125,6 +125,9 @@ class ActionModule(object):
changed = False
diffs = []
module_result = {"changed": False}
# Remove tmp path since a new one is created below. Should be empty.
if tmp.find("tmp") != -1:
self.runner._low_level_exec_command(conn, "rm -rf %s > /dev/null 2>&1" % tmp, tmp)
for source_full, source_rel in source_files:
# We need to get a new tmp path for each file, otherwise the copy module deletes the folder.
tmp = self.runner._make_tmp_path(conn)