ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

require git when trying to use it in ansible-galaxy cli (#49212)

Browse source 
* require git when trying to use it in ansible-galaxy cli

Previously we weren't setting `required=True` when calling
`get_bin_path` and the path would return `None`, this would cause
a traceback when attempting to ' '.join() to create a string
representation of the failed command for error output

Fixes #49200

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
This commit is contained in:
Adam Miller 2018-11-28 12:28:21 -06:00 committed by ansibot
parent 7a81d859c5
commit 81540bd754
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/49212-require-git-ansible-galaxy.yaml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- "ansible-galaxy: properly warn when git isn't found in an installed bin path instead of traceback"

2
lib/ansible/playbook/role/requirement.py
View file

@ -154,7 +154,7 @@ class RoleRequirement(RoleDefinition):
raise AnsibleError("- scm %s is not currently supported" % scm) raise AnsibleError("- scm %s is not currently supported" % scm)
try: try:
scm_path = get_bin_path(scm) scm_path = get_bin_path(scm, required=True)
except (ValueError, OSError, IOError): except (ValueError, OSError, IOError):
raise AnsibleError("could not find/use %s, it is required to continue with installing %s" % (scm, src)) raise AnsibleError("could not find/use %s, it is required to continue with installing %s" % (scm, src))