ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

VMware: vmware_guest_disk support for use_instance_uuid (#56107)

Browse source 
All vmware_guest_* module support for use_instance_uuid from Ansible 2.8,
somehow vmware_guest_disk missed from this change.
This fix adds support for use_instance_uuid in vmware_guest_disk.

Fixes: #56021

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde 2019-05-11 11:58:13 +05:30 committed by GitHub
parent 9f86257a65
commit 7e6be4e634
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/56021-vmware_guest_disk-use_instance_uuid.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- vmware_guest_disk module supports use_instance_uuid parameter since Ansible 2.8 (https://github.com/ansible/ansible/issues/56021).

6
lib/ansible/module_utils/vmware.py
View file

@ -882,10 +882,10 @@ class PyVmomi(object):
""" """
vm_obj = None vm_obj = None
user_desired_path = None user_desired_path = None
use_instance_uuid = self.params.get('use_instance_uuid') or False
if self.params['uuid'] and not self.params['use_instance_uuid']: if self.params['uuid'] and not use_instance_uuid:
vm_obj = find_vm_by_id(self.content, vm_id=self.params['uuid'], vm_id_type="uuid") vm_obj = find_vm_by_id(self.content, vm_id=self.params['uuid'], vm_id_type="uuid")
elif self.params['uuid'] and self.params['use_instance_uuid']: elif self.params['uuid'] and use_instance_uuid:
vm_obj = find_vm_by_id(self.content, vm_obj = find_vm_by_id(self.content,
vm_id=self.params['uuid'], vm_id=self.params['uuid'],
vm_id_type="instance_uuid") vm_id_type="instance_uuid")

7
lib/ansible/modules/cloud/vmware/vmware_guest_disk.py
View file

@ -60,6 +60,12 @@ options:
description: description:
- The datacenter name to which virtual machine belongs to. - The datacenter name to which virtual machine belongs to.
required: True required: True
use_instance_uuid:
description:
- Whether to use the VMWare instance UUID rather than the BIOS UUID.
default: no
type: bool
version_added: '2.8'
disk: disk:
description: description:
- A list of disks to add. - A list of disks to add.
@ -630,6 +636,7 @@ def main():
folder=dict(type='str'), folder=dict(type='str'),
datacenter=dict(type='str', required=True), datacenter=dict(type='str', required=True),
disk=dict(type='list', default=[]), disk=dict(type='list', default=[]),
use_instance_uuid=dict(type='bool', default=False),
) )
module = AnsibleModule(argument_spec=argument_spec, module = AnsibleModule(argument_spec=argument_spec,
required_one_of=[['name', 'uuid']]) required_one_of=[['name', 'uuid']])