ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fixes #39648 azure_rm_virtualnetwork not handling DNS settings properly on existing virtual networks (#40646)

Browse source 
* check nullable

* add test

* fix

* fix
This commit is contained in:
Yuwei Zhou 2018-05-28 15:45:01 +08:00 committed by Zim Kalinowski
parent dde48560fb
commit 7b9864776a
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/cloud/azure/azure_rm_virtualnetwork.py
View file

@ -257,7 +257,7 @@ class AzureRMVirtualNetwork(AzureRMModuleBase):
changed = True changed = True
if self.dns_servers: if self.dns_servers:
existing_dns_set = set(vnet.dhcp_options.dns_servers) existing_dns_set = set(vnet.dhcp_options.dns_servers) if vnet.dhcp_options else set([])
requested_dns_set = set(self.dns_servers) requested_dns_set = set(self.dns_servers)
if existing_dns_set != requested_dns_set: if existing_dns_set != requested_dns_set:
self.log('CHANGED: replacing DNS servers') self.log('CHANGED: replacing DNS servers')

11
test/integration/targets/azure_rm_virtualnetwork/tasks/main.yml
View file

@ -4,6 +4,17 @@
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
state: absent state: absent
- name: Create virtual network
azure_rm_virtualnetwork:
name: my_test_network
address_prefixes_cidr:
- 10.1.0.0/16
- 172.100.0.0/16
tags:
testing: testing
delete: on-exit
resource_group: "{{ resource_group }}"
- name: Create virtual network - name: Create virtual network
azure_rm_virtualnetwork: azure_rm_virtualnetwork:
name: my_test_network name: my_test_network