1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

udm_user: sanity (#5559)

* fix parameter email

* fix parameter groups

* fix parameters home_telephone_number, mail_alternative_address, mobile_telephone_number, pager_telephonenumber

* fix parameter phone

* fix parameter samba_privileges

* fix parameter samba_user_workstations

* fix parameter secretary

* fix parameter serviceprovider

* remove lines from ignore files

* add changelog fragment
This commit is contained in:
Alexei Znamensky 2022-11-24 06:43:58 +13:00 committed by GitHub
parent 5c1c8152ec
commit 79929830c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 29 additions and 10 deletions

View file

@ -0,0 +1,2 @@
minor_changes:
- udm_user - add ``elements`` attribute when missing in ``list`` parameters (https://github.com/ansible-collections/community.general/pull/5559).

View file

@ -78,6 +78,7 @@ options:
description: description:
- A list of e-mail addresses. - A list of e-mail addresses.
type: list type: list
elements: str
employee_number: employee_number:
description: description:
- Employee number - Employee number
@ -99,6 +100,7 @@ options:
LDAP filter for each group as $GROUP: LDAP filter for each group as $GROUP:
C((&(objectClass=posixGroup)(cn=$GROUP)))." C((&(objectClass=posixGroup)(cn=$GROUP)))."
type: list type: list
elements: str
home_share: home_share:
description: description:
- "Home NFS share. Must be a LDAP DN, e.g. - "Home NFS share. Must be a LDAP DN, e.g.
@ -116,6 +118,7 @@ options:
- List of private telephone numbers. - List of private telephone numbers.
aliases: [ homeTelephoneNumber ] aliases: [ homeTelephoneNumber ]
type: list type: list
elements: str
homedrive: homedrive:
description: description:
- Windows home drive, e.g. C("H:"). - Windows home drive, e.g. C("H:").
@ -126,6 +129,7 @@ options:
- List of alternative e-mail addresses. - List of alternative e-mail addresses.
aliases: [ mailAlternativeAddress ] aliases: [ mailAlternativeAddress ]
type: list type: list
elements: str
mail_home_server: mail_home_server:
description: description:
- FQDN of mail server - FQDN of mail server
@ -142,6 +146,7 @@ options:
- Mobile phone number - Mobile phone number
aliases: [ mobileTelephoneNumber ] aliases: [ mobileTelephoneNumber ]
type: list type: list
elements: str
organisation: organisation:
description: description:
- Organisation - Organisation
@ -165,10 +170,12 @@ options:
- List of pager telephone numbers. - List of pager telephone numbers.
aliases: [ pagerTelephonenumber ] aliases: [ pagerTelephonenumber ]
type: list type: list
elements: str
phone: phone:
description: description:
- List of telephone numbers. - List of telephone numbers.
type: list type: list
elements: str
default: [] default: []
postcode: postcode:
description: description:
@ -201,12 +208,14 @@ options:
join." join."
aliases: [ sambaPrivileges ] aliases: [ sambaPrivileges ]
type: list type: list
elements: str
default: [] default: []
samba_user_workstations: samba_user_workstations:
description: description:
- Allow the authentication only on this Microsoft Windows host. - Allow the authentication only on this Microsoft Windows host.
aliases: [ sambaUserWorkstations ] aliases: [ sambaUserWorkstations ]
type: list type: list
elements: str
default: [] default: []
sambahome: sambahome:
description: description:
@ -221,11 +230,13 @@ options:
description: description:
- A list of superiors as LDAP DNs. - A list of superiors as LDAP DNs.
type: list type: list
elements: str
serviceprovider: serviceprovider:
default: [''] default: ['']
description: description:
- Enable user for the following service providers. - Enable user for the following service providers.
type: list type: list
elements: str
shell: shell:
default: '/bin/bash' default: '/bin/bash'
description: description:
@ -333,7 +344,8 @@ def main():
display_name=dict(type='str', display_name=dict(type='str',
aliases=['displayName']), aliases=['displayName']),
email=dict(default=[''], email=dict(default=[''],
type='list'), type='list',
elements='str'),
employee_number=dict(type='str', employee_number=dict(type='str',
aliases=['employeeNumber']), aliases=['employeeNumber']),
employee_type=dict(type='str', employee_type=dict(type='str',
@ -341,18 +353,21 @@ def main():
firstname=dict(type='str'), firstname=dict(type='str'),
gecos=dict(type='str'), gecos=dict(type='str'),
groups=dict(default=[], groups=dict(default=[],
type='list'), type='list',
elements='str'),
home_share=dict(type='str', home_share=dict(type='str',
aliases=['homeShare']), aliases=['homeShare']),
home_share_path=dict(type='str', home_share_path=dict(type='str',
aliases=['homeSharePath']), aliases=['homeSharePath']),
home_telephone_number=dict(default=[], home_telephone_number=dict(default=[],
type='list', type='list',
elements='str',
aliases=['homeTelephoneNumber']), aliases=['homeTelephoneNumber']),
homedrive=dict(type='str'), homedrive=dict(type='str'),
lastname=dict(type='str'), lastname=dict(type='str'),
mail_alternative_address=dict(default=[], mail_alternative_address=dict(default=[],
type='list', type='list',
elements='str',
aliases=['mailAlternativeAddress']), aliases=['mailAlternativeAddress']),
mail_home_server=dict(type='str', mail_home_server=dict(type='str',
aliases=['mailHomeServer']), aliases=['mailHomeServer']),
@ -360,6 +375,7 @@ def main():
aliases=['mailPrimaryAddress']), aliases=['mailPrimaryAddress']),
mobile_telephone_number=dict(default=[], mobile_telephone_number=dict(default=[],
type='list', type='list',
elements='str',
aliases=['mobileTelephoneNumber']), aliases=['mobileTelephoneNumber']),
organisation=dict(type='str', organisation=dict(type='str',
aliases=['organization']), aliases=['organization']),
@ -371,11 +387,13 @@ def main():
aliases=['override_pw_length']), aliases=['override_pw_length']),
pager_telephonenumber=dict(default=[], pager_telephonenumber=dict(default=[],
type='list', type='list',
elements='str',
aliases=['pagerTelephonenumber']), aliases=['pagerTelephonenumber']),
password=dict(type='str', password=dict(type='str',
no_log=True), no_log=True),
phone=dict(default=[], phone=dict(default=[],
type='list'), type='list',
elements='str'),
postcode=dict(type='str'), postcode=dict(type='str'),
primary_group=dict(type='str', primary_group=dict(type='str',
aliases=['primaryGroup']), aliases=['primaryGroup']),
@ -387,16 +405,20 @@ def main():
aliases=['roomNumber']), aliases=['roomNumber']),
samba_privileges=dict(default=[], samba_privileges=dict(default=[],
type='list', type='list',
elements='str',
aliases=['sambaPrivileges']), aliases=['sambaPrivileges']),
samba_user_workstations=dict(default=[], samba_user_workstations=dict(default=[],
type='list', type='list',
elements='str',
aliases=['sambaUserWorkstations']), aliases=['sambaUserWorkstations']),
sambahome=dict(type='str'), sambahome=dict(type='str'),
scriptpath=dict(type='str'), scriptpath=dict(type='str'),
secretary=dict(default=[], secretary=dict(default=[],
type='list'), type='list',
elements='str'),
serviceprovider=dict(default=[''], serviceprovider=dict(default=[''],
type='list'), type='list',
elements='str'),
shell=dict(default='/bin/bash', shell=dict(default='/bin/bash',
type='str'), type='str'),
street=dict(type='str'), street=dict(type='str'),

View file

@ -26,7 +26,6 @@ plugins/modules/rax.py use-argspec-type-path # fix needed
plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/udm_share.py validate-modules:parameter-list-no-elements plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
plugins/modules/udm_user.py validate-modules:parameter-list-no-elements
plugins/modules/xfconf.py validate-modules:return-syntax-error plugins/modules/xfconf.py validate-modules:return-syntax-error
plugins/modules/yarn.py use-argspec-type-path plugins/modules/yarn.py use-argspec-type-path
tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6 # django generated code tests/integration/targets/django_manage/files/base_test/simple_project/p1/manage.py compile-2.6 # django generated code

View file

@ -21,6 +21,5 @@ plugins/modules/rax.py use-argspec-type-path # fix needed
plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/udm_share.py validate-modules:parameter-list-no-elements plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
plugins/modules/udm_user.py validate-modules:parameter-list-no-elements
plugins/modules/xfconf.py validate-modules:return-syntax-error plugins/modules/xfconf.py validate-modules:return-syntax-error
plugins/modules/yarn.py use-argspec-type-path plugins/modules/yarn.py use-argspec-type-path

View file

@ -21,6 +21,5 @@ plugins/modules/rax.py use-argspec-type-path # fix needed
plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/udm_share.py validate-modules:parameter-list-no-elements plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
plugins/modules/udm_user.py validate-modules:parameter-list-no-elements
plugins/modules/xfconf.py validate-modules:return-syntax-error plugins/modules/xfconf.py validate-modules:return-syntax-error
plugins/modules/yarn.py use-argspec-type-path plugins/modules/yarn.py use-argspec-type-path

View file

@ -23,6 +23,5 @@ plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/udm_share.py validate-modules:parameter-list-no-elements plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
plugins/modules/udm_user.py import-3.11 # Uses deprecated stdlib library 'crypt' plugins/modules/udm_user.py import-3.11 # Uses deprecated stdlib library 'crypt'
plugins/modules/udm_user.py validate-modules:parameter-list-no-elements
plugins/modules/xfconf.py validate-modules:return-syntax-error plugins/modules/xfconf.py validate-modules:return-syntax-error
plugins/modules/yarn.py use-argspec-type-path plugins/modules/yarn.py use-argspec-type-path

View file

@ -23,6 +23,5 @@ plugins/modules/rhevm.py validate-modules:parameter-state-invalid-choice
plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path plugins/modules/ssh_config.py use-argspec-type-path # Required since module uses other methods to specify path
plugins/modules/udm_share.py validate-modules:parameter-list-no-elements plugins/modules/udm_share.py validate-modules:parameter-list-no-elements
plugins/modules/udm_user.py import-3.11 # Uses deprecated stdlib library 'crypt' plugins/modules/udm_user.py import-3.11 # Uses deprecated stdlib library 'crypt'
plugins/modules/udm_user.py validate-modules:parameter-list-no-elements
plugins/modules/xfconf.py validate-modules:return-syntax-error plugins/modules/xfconf.py validate-modules:return-syntax-error
plugins/modules/yarn.py use-argspec-type-path plugins/modules/yarn.py use-argspec-type-path