From 77bff99f3c54d4720c7cb4228b1f520d5aa9a765 Mon Sep 17 00:00:00 2001
From: Ganesh Nalawade <ganesh634@gmail.com>
Date: Fri, 10 Aug 2018 15:20:38 +0530
Subject: [PATCH] Fix eos_command integration test failures (#43922)

---
 .../eos_command/tests/cli/cli_command.yaml    | 86 +++++++++++--------
 1 file changed, 50 insertions(+), 36 deletions(-)

diff --git a/test/integration/targets/eos_command/tests/cli/cli_command.yaml b/test/integration/targets/eos_command/tests/cli/cli_command.yaml
index 052de883e3..bff29a6075 100644
--- a/test/integration/targets/eos_command/tests/cli/cli_command.yaml
+++ b/test/integration/targets/eos_command/tests/cli/cli_command.yaml
@@ -2,48 +2,62 @@
 - debug:
     msg: "START cli/cli_command.yaml on connection={{ ansible_connection }}"
 
-- name: get output for single command
-  cli_command:
-    command: show version
-  register: result
+- block:
+  - name: get output for single command
+    cli_command:
+      command: show version
+    register: result
 
-- assert:
-    that:
-      - "result.changed == false"
-      - "result.stdout is defined"
+  - assert:
+      that:
+        - "result.changed == false"
+        - "result.stdout is defined"
 
-- name: send invalid command
-  cli_command:
-    command: 'show foo'
-  register: result
-  ignore_errors: yes
+  - name: send invalid command
+    cli_command:
+      command: 'show foo'
+    register: result
+    ignore_errors: yes
 
-- assert:
-    that:
-      - "result.failed == true"
-      - "result.msg is defined"
+  - assert:
+      that:
+        - "result.failed == true"
+        - "result.msg is defined"
 
-- name: get output in JSON format
-  cli_command:
-    command: show version | json
-  register: result
+  - name: get output in JSON format
+    cli_command:
+      command: show version | json
+    register: result
 
-- assert:
-    that:
-      - "result.changed == false"
-      - "result.stdout is defined"
-      - "result.json is defined"
+  - assert:
+      that:
+        - "result.changed == false"
+        - "result.stdout is defined"
+        - "result.json is defined"
 
-- name: command that does require become (should fail)
-  cli_command:
-    command: show running-config
-  become: no
-  ignore_errors: yes
-  register: result
+  - name: command that does require become (should fail)
+    cli_command:
+      command: show running-config
+    become: no
+    ignore_errors: yes
+    register: result
 
-- assert:
-    that:
-      - 'result.failed == true'
-      - '"privileged mode required" in result.msg'
+  - assert:
+      that:
+        - 'result.failed == true'
+        - '"privileged mode required" in result.msg'
+  when: "ansible_connection == 'network_cli'"
+
+- block:
+  - name: test failure for local connection
+    cli_command:
+      command: show version
+    register: result
+
+  - assert:
+      that:
+        - 'result.failed == true'
+        - "'Connection type local is not valid for this module' in result.msg"
+  when: "ansible_connection == 'local'"
 
 - debug: msg="END cli/cli_command.yaml on connection={{ ansible_connection }}"