From 7638d8ff4637d09eef3571879a54dd7353d55f86 Mon Sep 17 00:00:00 2001 From: Michael DeHaan Date: Sun, 23 Feb 2014 12:22:36 -0500 Subject: [PATCH] Update CODING_GUIDELINES.md --- CODING_GUIDELINES.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_GUIDELINES.md b/CODING_GUIDELINES.md index 6a3c497d48..7860fb2481 100644 --- a/CODING_GUIDELINES.md +++ b/CODING_GUIDELINES.md @@ -28,11 +28,11 @@ PEP8 and basic style checks Testing ======= - * Much of ansible's testing needs are in integration, not unit tests. We're working on releasing wide array of integration tests that use modules in a live environment. - * That being said, there are unit tests - * Code written must absolutely pass unit tests (i.e. "make tests") + * Much of ansible's testing needs are in integration, not unit tests. Add module tests there. + * That being said, there are unit tests too! + * Code written must absolutely pass tests (i.e. "make tests") * You should anticipate any error paths in your code and test down those error paths. - * Additions to unit tests for core code is welcome, but modules tend to be more integration-testey, so it's not always possible to add them (examples: ec2, etc). + * Additions to tests for core code is welcome, but not always possible. Be sure things are at least well tested manually in that case. Whitespace ==========