From 73b54139d65c94aac5f5b4ba251afa2d676cb12e Mon Sep 17 00:00:00 2001 From: Wilfried ROSET Date: Mon, 12 Aug 2024 07:42:05 +0200 Subject: [PATCH] fix(opentelemetry): adjust default value for `store_spans_in_file` causing traces to be produced to a file named `None` (#8741) * fix(opentelemetry): adjust default value for `store_spans_in_file` causing traces to be produced to a file named `None` The commit 5f481939d introduced `store_spans_in_file` with the default value `None` as a string. This causes the value of `store_spans_in_file` to be a not empty string, value=None as a string and not a null value. The rest of the code check if the store_spans_in_file is not null which squeezes the rest of the code. The following commit set the default value as an empty string. Signed-off-by: Wilfried Roset * fix(opentelemetry): No default value is better, reword changelog Signed-off-by: Wilfried Roset --------- Signed-off-by: Wilfried Roset --- changelogs/fragments/8741-fix-opentelemetry-callback.yml | 2 ++ plugins/callback/opentelemetry.py | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/8741-fix-opentelemetry-callback.yml diff --git a/changelogs/fragments/8741-fix-opentelemetry-callback.yml b/changelogs/fragments/8741-fix-opentelemetry-callback.yml new file mode 100644 index 0000000000..1b5e63a89f --- /dev/null +++ b/changelogs/fragments/8741-fix-opentelemetry-callback.yml @@ -0,0 +1,2 @@ +minor_changes: + - opentelemetry callback plugin - fix default value for ``store_spans_in_file`` causing traces to be produced to a file named ``None`` (https://github.com/ansible-collections/community.general/issues/8566, https://github.com/ansible-collections/community.general/pull/8741). diff --git a/plugins/callback/opentelemetry.py b/plugins/callback/opentelemetry.py index 2b2a5706fc..8dc627c214 100644 --- a/plugins/callback/opentelemetry.py +++ b/plugins/callback/opentelemetry.py @@ -85,7 +85,6 @@ DOCUMENTATION = ''' key: disable_attributes_in_logs version_added: 7.1.0 store_spans_in_file: - default: None type: str description: - It stores the exported spans in the given file